net: stmmac: FPE via ethtool + tc
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest7 patches 1 replyApplied 7/7
- v97 patches 4 repliesSuperseded
- v87 patches 5 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 7 patches | 6 replies | Superseded | |
| v6 | 7 patches | 1 reply | Superseded | |
| v5 | 7 patches | 2 replies | Superseded | |
| v4 | 7 patches | 10 replies | Superseded | |
| v3 | 7 patches | 4 replies | Superseded | |
| v2 | 7 patches | 1 reply | Superseded | |
| v1 | 5 patches | 9 replies | Superseded |
Changes in v10 from the cover letter
1. fixed a stacktrace caused by timer_shutdown_sync() on an uninitialized timer
2. ignore FPE_EVENT_RRSP events if we are not in the ETHTOOL_MM_VERIFY_STATUS_VERIFYING state
Patches in v10 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | net: stmmac: move stmmac_fpe_cfg to stmmac_priv datadrivers/ drivers/ drivers/ +2 more | +44 | 0 replies | Applied |
| 2/7 | net: stmmac: drop stmmac_fpe_handshakedrivers/ drivers/ drivers/ | +1 | 0 replies | Applied |
| 3/7 | net: stmmac: refactor FPE verification processdrivers/ drivers/ drivers/ +5 more | +166 | 0 replies | Applied |
| 4/7 | net: stmmac: configure FPE via ethtool-mmdrivers/ drivers/ drivers/ +2 more | +126 | 0 replies | Applied |
| 5/7 | net: stmmac: support fp parameter of tc-mqpriodrivers/ drivers/ drivers/ +4 more | +172 | 0 replies | Applied |
| 6/7 | net: stmmac: support fp parameter of tc-tapriodrivers/ | +22 | 0 replies | Applied |
| 7/7 | net: stmmac: silence FPE kernel logsdrivers/ drivers/ | +4 | 0 replies | Applied |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Oltean | Serge Semin |
|---|---|---|
| 1/7 | R-b | R-b |
| 2/7 | R-b | |
| 3/7 | R-b | |
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | R-b | |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v10 0/7] net: stmmac: FPE via ethtool + tc
Move the Frame Preemption(FPE) over to the new standard API which uses ethtool-mm/tc-mqprio/tc-taprio.
Changes in v10:
1. fixed a stacktrace caused by timer_shutdown_sync() on an uninitialized timer
2. ignore FPE_EVENT_RRSP events if we are not in the ETHTOOL_MM_VERIFY_STATUS_VERIFYING state
Changes in v9:
1. drop redundant netif_device_present() since ethnl_ops_begin() has its own netif_device_present() call
2. open-code some variables of struct ethtool_mm_state directly in struct stmmac_fpe_cfg
3. convert timer_delete_sync() to timer_shutdown_sync(), thus the timer will not be rearmed again
4. fixed variable declarations in the middle of the scope
Changes in v8:
1. use timer_delete_sync() instead of deprecated del_timer_sync()
2. check netif_running() to guarantee synchronization rules between mod_timer() and timer_delete_sync()
3. split up stmmac_tc_ops of dwmac4, dwmac4+ and dwxgmac to give user more descriptive error message
4. fix wrong indentation about switch-case
5. delete more unbalanced logs
Changes in v7:
1. code style fixes and clean up warnings reported by patchwork netdev checks, no functional change intended
Changes in v6:
1. new FPE verification process based on Vladimir Oltean's proposal
2. embed ethtool_mm_state into stmmac_fpe_cfg
3. convert some bit ops to u32_replace_bits
4. register name and function name update to be more descriptive
5. split up stmmac_tc_ops of dwmac4+ and dwxgmac, they have different implementations about mqprio
6. some code style fixes
Changes in v5:
1. fix typo in commit message
2. drop FPE capability check in tc-mqprio/tc-taprio
Changes in v4:
1. reorder FPE-related declarations and definitions into clean groups
2. move mm_lock to stmmac_fpe_cfg.lock
3. protect user configurations across NIC up/down
4. block stmmac_set_mm() when fpe_task is in progress to finish
5. convert to ethtool_dev_mm_supported() to check FPE capability in tc-mqprio/tc-taprio
6. silence FPE workqueue start/stop logs
Changes in v3:
1. avoid races among ISR, workqueue, link update and register configuration.
2. update FPE verification retry logic, so it retries and fails as expected.
Changes in v2:
1. refactor FPE verification process
2. suspend/resume and kselftest-ethtool_mm, all test cases passed
3. handle TC:TXQ remapping for DWMAC CORE4+
Furong Xu (7):
net: stmmac: move stmmac_fpe_cfg to stmmac_priv data
net: stmmac: drop stmmac_fpe_handshake
net: stmmac: refactor FPE verification process
net: stmmac: configure FPE via ethtool-mm
net: stmmac: support fp parameter of tc-mqprio
net: stmmac: support fp parameter of tc-taprio
net: stmmac: silence FPE kernel logs
.../net/ethernet/stmicro/stmmac/dwmac4_core.c | 10 +- drivers/net/ethernet/stmicro/stmmac/dwmac5.c | 96 +++++- drivers/net/ethernet/stmicro/stmmac/dwmac5.h | 12 +- .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 9 +- drivers/net/ethernet/stmicro/stmmac/hwif.c | 6 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 22 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 35 ++- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 96 ++++++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 273 ++++++++---------- .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 153 +++++++--- include/linux/stmmac.h | 28 -- 11 files changed, 497 insertions(+), 243 deletions(-)
Signature · 1 line
2.34.1