btrfs: clean up btrfs_iget, btrfs_iget_path usage
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 3 repliesIn review
- v12 patches 1 replySuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: remove conditional path allocation from read_locked_inode, add path allocation to igetfs/ | +14 | 2 replies | |
| 2/2 | btrfs: move clean up code from btrfs_iget_path to btrfs_read_locked_inodefs/ | +51 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Josef Bacik |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] btrfs: clean up btrfs_iget, btrfs_iget_path usage
The first patch moves the path allocation from inside btrfs_read_locked_inode to btrfs_iget. This makes the code easier to reason about as it is clear where the allocation occurs and who is in charge of freeing the path.
The second patch moves the clean up code from btrfs_iget_path into btrfs_read_locked_inode simplifyiung btrfs_iget_path.
Version 2 includes the modifications suggested by David Sterba:
Patch 1/2:
- Added an ASSERT(path) to make sure that btrfs_read_locked_inode is never called with a null path.
- Fixed btrfs_iget to more closely match btrfs standards. Contiguous declaration at the top, with no non-trivial assignments.
Leo Martins (2):
btrfs: remove conditional path allocation from read_locked_inode, add
path allocation to iget
btrfs: move clean up code from btrfs_iget_path to
btrfs_read_locked_inode
fs/btrfs/inode.c | 128 +++++++++++++++++++++++------------------------ 1 file changed, 64 insertions(+), 64 deletions(-)
Signature · 1 line
2.43.5