Skip to content

Update page fault queue size calculation

Stuart Summers intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/xe: Fix missing workqueue destroy in xe_gt_pagefaultdrivers/gpu/drm/xe/xe_gt_pagefault.c+16 -20 replies
2/3drm/xe: Use topology to determine page fault queue sizedrivers/gpu/drm/xe/xe_gt_pagefault.c drivers/gpu/drm/xe/xe_gt_types.h+49 -140 replies
3/3drm/xe/guc: Bump the G2H queue size to account for page faultsdrivers/gpu/drm/xe/xe_guc_ct.c+10 -20 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostRodrigo Vivi
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [CI 0/3] Update page fault queue size calculation

Right now the page fault queue size is hard coded with an estimated value based on legacy platforms. Add a more precise calculation based on the number of compute resources available which can utilize these page fault queues.

v2: Add a drm reset callback for the teardown changes and other
suggestions from Matt.
v3: Add a pf_wq destroy when the access counter wq allocation
fails (Rodrigo) and pf queue size calculation adjustment (Matt)
v4: Bump up the size of the G2H queue as well (Matt)
v5: Make the G2H buffer size 64K (Matt)
v6: Rebase and resend for CI
v7: Rebase (again) and resend for CI
The prior series was showing an unexpected failure in some of the display tests. I tried running the main one manually after rebasing this series again recently and it passed on manual execution, so giving this series another try on CI with the expectation that those prior issues were unrelated to my series. Here's the test I ran manually:
igt@kms_cursor_edge_walk@64x64-top-bottom

Stuart Summers (3):
drm/xe: Fix missing workqueue destroy in xe_gt_pagefault drm/xe: Use topology to determine page fault queue size drm/xe/guc: Bump the G2H queue size to account for page faults

 drivers/gpu/drm/xe/xe_gt_pagefault.c | 72 ++++++++++++++++++++++------
 drivers/gpu/drm/xe/xe_gt_types.h     |  9 +++-
 drivers/gpu/drm/xe/xe_guc_ct.c       | 12 ++++-
 3 files changed, 75 insertions(+), 18 deletions(-)
Signature · 1 line
2.34.1