Skip to content

arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset

Steve Clevenger linux-arm-kernel linux-perf-users 10 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest2 patches 2 repliesApplied
  2. v92 patches 11 repliesSuperseded
  3. v84 patches 9 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v74 patches5 repliesSuperseded
v64 patches2 repliesSuperseded
v52 of 4 patches7 repliesSuperseded
v44 patches8 repliesSuperseded
v34 patches1 replySuperseded
v25 patches5 repliesSuperseded
v15 patches2 repliesSuperseded

Changes in v11 from the cover letter

- Corrected prefix.
- Fixed compile-time error for perf debug build by substituting in the map__pgoff macro (trace_event_python.c).

Patches in v11 Applied

#Subject and filesSizeRepliesApplied
1/2perf script cs_etm: Add map_pgoff to python dictionarytools/perf/util/scripting-engines/trace-event-python.c+6 -30 replies
2/2perf script python: Adjust objdump start/end per map pgoff parametertools/perf/scripts/python/arm-cs-trace-disasm.py+11 -50 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLeo Yan
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v11 thread

Cover letter [PATCH V11 0/2] arm-cs-trace-disasm.py/perf must accommodate non-zero DSO text offset

Changes in V11:
- Corrected prefix.
- Fixed compile-time error for perf debug build by substituting in the map__pgoff macro (trace_event_python.c).

Changes in V10:
- Removed errant space in patch file 0002. Passed 'git apply --check'

    at perf-tools-next, 6.11.0-rc6.

- Added back missing prefixes.

Changes in V9:
- Removed V8 patch files 1/4 and 2/4.
- Modified set_sym_in_dict (trace-event-python.c) to add map_pgoff in dictionary as-is without regard to MAPPING_IDENTITY. This patch file is now patch 2/2.

Changes in V8:
- in arm-cs-trace-disasm.py, ensure map_pgoff is not converted to string.
- Remove map_pgoff integer conversion in dso not found print message.

Changes in V7:
- In arm-cs-trace-disasm.py, fix print message core dump resulting from mixed type arithmetic.
- Modify CS_ETM_TRACE_ON filter to filter zero start_addr. The CS_ETM_TRACE_ON message is changed to print only in verbose mode.
- Removed verbose mode only notification for start_addr/stop_addr outside of dso address range.

Changes in V6:
- In arm-cs-trace-disasm.py, zero map_pgoff for kernel files. Add map_pgoff to start/end address for dso not found message.
- Added "Reviewed-by" trailer for patches 1-3 previously reviewed by Leo Yan in V4 and V5.

Changes in V5:
- In symbol-elf.c, branch to exit_close label if open file.
- In trace_event_python.c, correct indentation. set_sym_in_dict call parameter "map_pgoff" renamed as "addr_map_pgoff" to match local naming.

Changes in V4:
- In trace-event-python.c, fixed perf-tools-next merge problem.

Changes in V3:
- Rebased to linux-perf-tools branch.
- Squash symbol-elf.c and symbol.h into same commit.
- In map.c, merge dso__is_pie() call into existing if statement.
- In arm-cs-trace-disasm.py, remove debug artifacts.

Changes in V2:
- In dso__is_pie() (symbol-elf.c), Decrease indentation, add null pointer checks per Leo Yan review.

Steve Clevenger (2):
perf script cs_etm: Add map_pgoff to python dictionary perf script python: Adjust objdump start/end per map pgoff parameter

 tools/perf/scripts/python/arm-cs-trace-disasm.py | 16 +++++++++++-----
 .../util/scripting-engines/trace-event-python.c  |  9 ++++++---
 2 files changed, 17 insertions(+), 8 deletions(-)
Signature · 1 line
2.44.0