Skip to content

Improve error handling in Rockchip Inno USB 2.0 PHY driver

Dragan Simic linux-arm-kernel linux-phy linux-rockchip lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesApplied
  2. v23 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Collected Reviewed-by tags from Heiko for patches 1/3 and 2/3
- Brought back one empty line as a separator of dissimilar operations in patch 1/3, as suggested by Heiko [2]
- Dropped one backward conversion of dev_err_probe() to dev_err() in patch 3/3, as suggested by Heiko, [3] and adjusted the summary and description of patch 3/3 accordingly

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3phy: phy-rockchip-inno-usb2: Perform trivial code cleanupsdrivers/phy/rockchip/phy-rockchip-inno-usb2.c+9 -170 replies
2/3phy: phy-rockchip-inno-usb2: Handle failed extcon allocation betterdrivers/phy/rockchip/phy-rockchip-inno-usb2.c+2 -10 replies
3/3phy: phy-rockchip-inno-usb2: Use dev_err_probe() in the probe pathdrivers/phy/rockchip/phy-rockchip-inno-usb2.c+10 -171 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHeiko Stuebner
1/3R-b
2/3Helped-by R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] Improve error handling in Rockchip Inno USB 2.0 PHY driver

This is a small series that improves error handling in the probe path of the Rockchip Innosilicon USB 2.0 PHY driver, by returning the actual error code in one place and by using dev_err_probe() properly in multiple places. It also performs a bunch of small, rather trivial code cleanups, to make the code neater and a bit easier to read.

Changes in v3:
- Collected Reviewed-by tags from Heiko for patches 1/3 and 2/3
- Brought back one empty line as a separator of dissimilar operations in patch 1/3, as suggested by Heiko [2]
- Dropped one backward conversion of dev_err_probe() to dev_err() in patch 3/3, as suggested by Heiko, [3] and adjusted the summary and description of patch 3/3 accordingly

Changes in v2:
- Expanded into a small series, after a suggestion from Heiko [1] to use dev_err_probe(), because it all happens in the probe path

Link to v2: https://lore.kernel.org/linux-phy/[email protected]/T/#u
Link to v1: https://lore.kernel.org/linux-phy/5fa7796d71e2f46344e972bc98a54539f55b6109.1723551599.git.dsimic@manjaro.org/T/#u

[1] https://lore.kernel.org/linux-phy/4927264.xgNZFEDtJV@diego/
[2] https://lore.kernel.org/linux-phy/5307900.6fTUFtlzNn@diego/
[3] https://lore.kernel.org/linux-phy/6073817.31tnzDBltd@diego/

Dragan Simic (3):
phy: phy-rockchip-inno-usb2: Perform trivial code cleanups
phy: phy-rockchip-inno-usb2: Handle failed extcon allocation better
phy: phy-rockchip-inno-usb2: Use dev_err_probe() in the probe path

 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 56 +++++++------------
 1 file changed, 21 insertions(+), 35 deletions(-)