sfc: per-queue stats
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest7 patches 3 repliesApplied 7/7
- v3 RFC7 patches 0 repliesSuperseded
- v26 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 14 replies | Superseded |
Changes in v4 from the cover letter
* remove RFC tags
Patches in v4 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | sfc: remove obsolete counters from struct efx_channeldrivers/ drivers/ | +0 | 0 replies | Applied |
| 2/7 | sfc: implement basic per-queue statsdrivers/ drivers/ drivers/ +4 more | +108 | 1 reply | Applied |
| 3/7 | sfc: add n_rx_overlength to ethtool statsdrivers/ | +1 | 0 replies | Applied |
| 4/7 | sfc: account XDP TXes in netdev base statsdrivers/ drivers/ drivers/ +2 more | +39 | 1 reply | Applied |
| 5/7 | sfc: implement per-queue rx drop and overrun statsdrivers/ drivers/ drivers/ +1 more | +31 | 0 replies | Applied |
| 6/7 | sfc: implement per-queue TSO (hw_gso) statsdrivers/ drivers/ drivers/ | +22 | 0 replies | Applied |
| 7/7 | sfc: add per-queue RX bytes statsdrivers/ drivers/ drivers/ +2 more | +11 | 0 replies | Applied |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jacob Keller |
|---|---|
| Series | R-b |
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 net-next 0/7] sfc: per-queue stats
From: Edward Cree <[email protected]>
This series implements the netdev_stat_ops interface for per-queue
statistics in the sfc driver, partly using existing counters that were originally added for ethtool -S output.
Changed in v4:
* remove RFC tags
Changed in v3:
* make TX stats count completions rather than enqueues
* add new patch #4 to account for XDP TX separately from netdev traffic and include it in base_stats
* move the tx_queue->old_* members out of the fastpath cachelines
* note on patch #6 that our hw_gso stats still count enqueues
* RFC since net-next is closed right now
Changed in v2:
* exclude (dedicated) XDP TXQ stats from per-queue TX stats
* explain patch #3 better
Edward Cree (7):
sfc: remove obsolete counters from struct efx_channel
sfc: implement basic per-queue stats
sfc: add n_rx_overlength to ethtool stats
sfc: account XDP TXes in netdev base stats
sfc: implement per-queue rx drop and overrun stats
sfc: implement per-queue TSO (hw_gso) stats
sfc: add per-queue RX bytes stats
drivers/net/ethernet/sfc/ef100_rx.c | 5 +- drivers/net/ethernet/sfc/efx.c | 109 ++++++++++++++++++++++ drivers/net/ethernet/sfc/efx_channels.c | 6 ++ drivers/net/ethernet/sfc/efx_channels.h | 7 ++ drivers/net/ethernet/sfc/ethtool_common.c | 3 +- drivers/net/ethernet/sfc/net_driver.h | 47 +++++++++- drivers/net/ethernet/sfc/rx.c | 5 +- drivers/net/ethernet/sfc/rx_common.c | 3 + drivers/net/ethernet/sfc/tx.c | 6 +- drivers/net/ethernet/sfc/tx_common.c | 33 +++++-- drivers/net/ethernet/sfc/tx_common.h | 4 +- 11 files changed, 210 insertions(+), 18 deletions(-)