Skip to content

add mptcp_subflow bpf_iter

Geliang Tang mptcp 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest8 patches 2 repliesIn review
  2. v119 patches 2 repliesSuperseded
  3. v109 patches 0 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v97 patches17 repliesSuperseded
v87 patches2 repliesSuperseded
v77 patches2 repliesSuperseded
v610 patches2 repliesSuperseded
v55 patches13 repliesSuperseded
v45 patches2 repliesSuperseded
v35 patches7 repliesSuperseded
v24 patches2 repliesSuperseded
v14 patches6 repliesSuperseded

Changes in v12 from the cover letter

- squash patch 4 and patch 6 into one.
- use TCP_IS_MPTCP instead of TCP_CONGESTION.

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8bpf: Register mptcp common kfunc setnet/mptcp/bpf.c+30 -00 replies
2/8bpf: Add mptcp_subflow bpf_iternet/mptcp/bpf.c+45 -40 replies
3/8bpf: Acquire and release mptcp socketnet/mptcp/bpf.c+18 -00 replies
4/8selftests/bpf: More endpoints for endpoint_inittools/testing/selftests/bpf/prog_tests/mptcp.c+50 -60 replies
5/8selftests/bpf: Add mptcp_subflow bpf_iter subtesttools/testing/selftests/bpf/bpf_experimental.h tools/testing/selftests/bpf/prog_tests/mptcp.c tools/testing/selftests/bpf/progs/mptcp_bpf.h +1 more+153 -00 replies
6/8Squash to "selftests/bpf: Add bpf scheduler test"tools/testing/selftests/bpf/prog_tests/mptcp.c+1 -10 replies
7/8Revert "bpf: Export more bpf_burst related functions"net/mptcp/bpf.c net/mptcp/protocol.c net/mptcp/protocol.h+2 -160 replies
8/8Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"net/mptcp/bpf.c net/mptcp/protocol.c net/mptcp/protocol.h+15 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v12 yet.

Read the v12 thread

Cover letter [PATCH mptcp-next v12 0/8] add mptcp_subflow bpf_iter

From: Geliang Tang <[email protected]>

v12:
- squash patch 4 and patch 6 into one.
- use TCP_IS_MPTCP instead of TCP_CONGESTION.

v11:
- fix building errors in v10.
- update patch 5, change bpf test IP addresses more like that of mptcp join selftests from:

	#define ADDR_1	"10.0.1.1"
	#define ADDR_2	"10.0.1.2"
	#define ADDR_3	"10.0.1.3"
	#define ADDR_4	"10.0.1.4"

to

	#define ADDR_1 "10.0.1.1"
	#define ADDR_2 "10.0.2.1"
	#define ADDR_3 "10.0.3.1"
	#define ADDR_4 "10.0.4.1"

This ensures that it can be expanded to two namespaces in the future.

v10:
- rename bpf prog to "mptcp_bpf_iters.c" and change it as "cgroup/getsockopt" type. Since another bpf_iter "mptcp_address", to traverse all address entries on userspace_pm_local_addr_list of an MPTCP socket for implementing the MPTCP BPF path manager, will be added in the next set. The test program for "mptcp_address" bpf_iter will be added into this "mptcp_bpf_iters.c" file too and also defined as "cgroup/getsockopt" type.
- change all bpf kfunc static as Matt suggested.
- drop mptcp_subflow_active and mptcp_subflow_set_scheduled from the test program as Matt suggested.

v9:
- rename bpf prog to "mptcp_bpf_iters_subflow.c"
- drop the helper bpf_mptcp_sk(), it's not used in this test.

v8:
- Make the test prog in patch 4 more like a bpf packet scheduler.
- Export more mptcp helpers into BPF in patch 1.

v7:
- As Martin recently replied, mptcp_stubflow bpf_iter can still be
used in tracing. So go back to the tracing selftest.

v6:
- add KF_TRUSTED_ARGS flag in patch 2 (Andrii, Martin), then acquire
and release helpers (patch 3) are needed to be implemented.
- test mptcp_subflow bpf_iter in "cgroup/getsockopt" (patch 5),
instead of testing them in "tracing" (Martin).

v5:
- update patch 1 as Andrii suggested: if msk is NULL, initialize
kit->msk to NULL in _new() and check it in _next().

v4:
- squash patch 1/5 and 3/5 in v3 together as Matt suggested.
- a new squash-to patch to drop mptcp_subflow_active declaration in bpf_burst.

v3:
- drop bpf_iter__mptcp_subflow, __diag_push, __diag_pop and __diag_ignore_all
- drop declarations for bpf kfuncs

v2:
- update patch 1 as Martin and Andrii suggested.
- fix warnings and errors reported by MPTCP CI.

This patch set adds a mptcp_subflow type bpf_iter, and self tests.

Geliang Tang (8):
bpf: Register mptcp common kfunc set
bpf: Add mptcp_subflow bpf_iter
bpf: Acquire and release mptcp socket selftests/bpf: More endpoints for endpoint_init selftests/bpf: Add mptcp_subflow bpf_iter subtest Squash to "selftests/bpf: Add bpf scheduler test" Revert "bpf: Export more bpf_burst related functions" Squash to "bpf: Add bpf_mptcp_sched_kfunc_set"

 net/mptcp/bpf.c                               |  99 ++++++++++++-
 net/mptcp/protocol.h                          |   1 -
 .../testing/selftests/bpf/bpf_experimental.h  |   7 +
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 131 +++++++++++++++++-
 tools/testing/selftests/bpf/progs/mptcp_bpf.h |   9 ++
 .../selftests/bpf/progs/mptcp_bpf_iters.c     |  64 +++++++++
 6 files changed, 298 insertions(+), 13 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_iters.c
Signature · 1 line
2.43.0