Skip to content

regulator: max77826: Constify and simplify

Christophe JAILLET kernel-janitors lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2regulator: max77826: Constify struct regulator_descdrivers/regulator/max77826-regulator.c+2 -21 reply
2/2regulator: max77826: Simplify max77826_i2c_probe()drivers/regulator/max77826-regulator.c+0 -181 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchIskren Chernev
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] regulator: max77826: Constify and simplify

Patch 1 is just a constification path. It should be straighforward.

Patch 2 is COMPLETELY SPECULATIVE. Some code and memory allocation *LOOK* useless. So review with care!
Looking are lore does not give any information about this code to me.
v1: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/

It *looks* like code written to release some resources in a .remove() function, maybe used before switchwing to devm_ function.

Christophe JAILLET (2):
regulator: max77826: Constify struct regulator_desc
regulator: max77826: Simplify max77826_i2c_probe()

 drivers/regulator/max77826-regulator.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)
Signature · 1 line
2.46.0