Skip to content

Prepare GHES driver to support error injection

Mauro Carvalho Chehab kvm lkml qemu-arm qemu-devel 7 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest16 patches 0 repliesNew
  2. v616 patches 7 repliesSuperseded
  3. v516 patches 10 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v415 patches17 repliesSuperseded
v315 patches5 repliesSuperseded
v215 patches9 repliesSuperseded
v115 patches20 repliesSuperseded

Changes in v7 from the cover letter

- addressed minor nits on patch 9

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVEDhw/acpi/ghes.c include/hw/acpi/ghes.h+4 -60 replies
2/16acpi/ghes: simplify acpi_ghes_record_errors() codehw/acpi/ghes.c+29 -270 replies
3/16acpi/ghes: simplify the per-arch caller to build HEST tablehw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+9 -70 replies
4/16acpi/ghes: better handle source_id and notificationhw/acpi/ghes.c+9 -140 replies
5/16acpi/ghes: Fix acpi_ghes_record_errors() argumentinclude/hw/acpi/ghes.h+1 -10 replies
6/16acpi/ghes: Remove a duplicated out of bounds checkhw/acpi/ghes.c+1 -30 replies
7/16acpi/ghes: Change the type for source_idhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h+3 -30 replies
8/16acpi/ghes: don't check if physical_address is not zerohw/acpi/ghes.c+0 -40 replies
9/16acpi/ghes: make the GHES record generation more generichw/acpi/ghes.c include/hw/acpi/ghes.h+72 -510 replies
10/16acpi/ghes: better name GHES memory error functionhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h +1 more+5 -50 replies
11/16acpi/ghes: don't crash QEMU if ghes GED is not foundhw/acpi/ghes.c+4 -10 replies
12/16acpi/ghes: rename etc/hardware_error file macroshw/acpi/ghes.c+23 -150 replies
13/16acpi/ghes: better name the offset of the hardware error firmwarehw/acpi/generic_event_device.c hw/acpi/ghes.c include/hw/acpi/ghes.h+5 -50 replies
14/16acpi/ghes: move offset calculus to a separate functionhw/acpi/ghes.c+31 -90 replies
15/16acpi/ghes: Change ghes fill logic to work with only one sourcehw/acpi/ghes.c+4 -80 replies
16/16docs: acpi_hest_ghes: fix documentation for CPER sizedocs/specs/acpi_hest_ghes.rst+4 -20 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronIgor Mammedov
1/16R-b R-b
2/16R-b R-b
3/16R-b R-b
4/16R-b R-b
5/16R-b R-b
6/16R-b R-b
7/16R-b R-b
8/16R-b R-b
9/16R-b R-b
10/16R-b R-b
11/16R-b R-b
12/16R-b R-b
13/16R-b R-b
14/16R-b
15/16R-b R-b
16/16R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 00/16] Prepare GHES driver to support error injection

During the development of a patch series meant to allow GHESv2 error injections, it was requested a change on how CPER offsets are calculated, by adding a new BIOS pointer and reworking the GHES logic. See:

https://lore.kernel.org/qemu-devel/[email protected]/

Such change ended being a big patch, so several intermediate steps are needed, together with several cleanups and renames.

As agreed duing v10 review, I'll be splitting the big patch series into separate pull requests, starting with the cleanup series. This is the first patch set, containing only such preparation patches.

The next series will contain the shift to use offsets from the location of the HEST table, together with a migration logic to make it compatible with 9.1.

---

v7:
- addressed minor nits on patch 9

v6:
- some changes at patches description and added some R-B;
- no changes at the code.

v5:
- added a new patch:
acpi/ghes: don't check if physical_address is not zero
- removed a duplicated le64_to_cpu();
- changed a comment about writing 1 to read ack register.

v4:
- merged a patch renaming the function which calculate offsets to:
get_hw_error_offsets(), to avoid the need of such change at the next patch series;
- removed a functional change at the logic which makes
the GHES record generation more generic;
- a couple of trivial changes on patch descriptions and line break cleanups.

v3:
- improved some patch descriptions;
- some patches got reordered to better reflect the changes;
- patch v2 08/15: acpi/ghes: Prepare to support multiple sources on ghes was split on two patches. The first one is in this cleanup series:
acpi/ghes: Change ghes fill logic to work with only one source
contains just the simplification logic. The actual preparation will be moved to this series:

     https://lore.kernel.org/qemu-devel/[email protected]/

v2:
- some indentation fixes;
- some description improvements;
- fixed a badly-solved merge conflict that ended renaming a parameter.

Mauro Carvalho Chehab (16):
acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED acpi/ghes: simplify acpi_ghes_record_errors() code acpi/ghes: simplify the per-arch caller to build HEST table acpi/ghes: better handle source_id and notification acpi/ghes: Fix acpi_ghes_record_errors() argument acpi/ghes: Remove a duplicated out of bounds check acpi/ghes: Change the type for source_id
acpi/ghes: don't check if physical_address is not zero acpi/ghes: make the GHES record generation more generic acpi/ghes: better name GHES memory error function acpi/ghes: don't crash QEMU if ghes GED is not found acpi/ghes: rename etc/hardware_error file macros acpi/ghes: better name the offset of the hardware error firmware acpi/ghes: move offset calculus to a separate function acpi/ghes: Change ghes fill logic to work with only one source
docs: acpi_hest_ghes: fix documentation for CPER size

 docs/specs/acpi_hest_ghes.rst  |   6 +-
 hw/acpi/generic_event_device.c |   4 +-
 hw/acpi/ghes-stub.c            |   2 +-
 hw/acpi/ghes.c                 | 258 +++++++++++++++++++--------------
 hw/arm/virt-acpi-build.c       |   5 +-
 include/hw/acpi/ghes.h         |  16 +-
 target/arm/kvm.c               |   2 +-
 7 files changed, 168 insertions(+), 125 deletions(-)
Signature · 1 line
2.47.1