Skip to content

drm/i915/irq: clean up irq reset/init macro hacks

Jani Nikula intel-gfx intel-xe 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/i915/irq: add struct i915_irq_regs tripletdrivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_irq.h drivers/gpu/drm/i915/i915_reg_defs.h +1 more+51 -512 replies
2/3drm/i915/irq: remove GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macrosdrivers/gpu/drm/i915/display/intel_display_irq.c drivers/gpu/drm/i915/gt/intel_gt_irq.c drivers/gpu/drm/i915/gt/intel_gt_regs.h +3 more+84 -421 reply
3/3drm/i915/irq: remove GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX() macrosdrivers/gpu/drm/i915/display/intel_display_irq.c drivers/gpu/drm/i915/gt/intel_gt_irq.c drivers/gpu/drm/i915/i915_irq.h +1 more+25 -341 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchRodrigo Vivi
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] drm/i915/irq: clean up irq reset/init macro hacks

Add a struct to hold IMR/IER/IIR registers, and pass them together instead of the ugly macro hacks with macro name concatenation etc.

BR,
Jani.

Jani Nikula (3):
drm/i915/irq: add struct i915_irq_regs triplet drm/i915/irq: remove GEN3_IRQ_RESET() and GEN3_IRQ_INIT() macros drm/i915/irq: remove GEN8_IRQ_RESET_NDX() and GEN8_IRQ_INIT_NDX()
macros

 .../gpu/drm/i915/display/intel_display_irq.c  | 52 ++++++++--------
 drivers/gpu/drm/i915/gt/intel_gt_irq.c        | 24 ++++----
 drivers/gpu/drm/i915/gt/intel_gt_regs.h       |  4 ++
 drivers/gpu/drm/i915/i915_irq.c               | 59 +++++++++----------
 drivers/gpu/drm/i915/i915_irq.h               | 34 +----------
 drivers/gpu/drm/i915/i915_reg.h               | 53 +++++++++++++++++
 drivers/gpu/drm/i915/i915_reg_defs.h          | 10 ++++
 drivers/gpu/drm/xe/display/ext/i915_irq.c     | 31 +++++-----
 8 files changed, 150 insertions(+), 117 deletions(-)
Signature · 1 line
2.39.2