Skip to content

btrfs: backref cache cleanups

Josef Bacik linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10btrfs: convert BUG_ON in btrfs_reloc_cow_block to proper error handlingfs/btrfs/relocation.c+14 -21 reply
2/10btrfs: remove the changed list for backref cachefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+8 -180 replies
3/10btrfs: add a comment for new_bytenr in bacref_cache_nodefs/btrfs/backref.h+6 -01 reply
4/10btrfs: cleanup select_reloc_rootfs/btrfs/relocation.c+61 -831 reply
5/10btrfs: remove clone_backref_nodefs/btrfs/relocation.c+1 -900 replies
6/10btrfs: don't build backref tree for cowonly blocksfs/btrfs/relocation.c+70 -191 reply
7/10btrfs: do not handle non-shareable roots in backref cachefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+36 -300 replies
8/10btrfs: simplify btrfs_backref_release_cachefs/btrfs/backref.c+2 -200 replies
9/10btrfs: remove the ->lowest and ->leaves members from backref cachefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+0 -300 replies
10/10btrfs: remove detached list from btrfs_backref_cachefs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+0 -50 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Burkov
SeriesR-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] btrfs: backref cache cleanups

Hello,

This is the followup to the relocation fix that I sent out earlier. This series cleans up a lot of the complicated things that exist in backref cache because we were keeping track of changes to the file system during relocation. Now that we do not do this we can simplify a lot of the code and make it easier to understand. I've tested this with the horror show of a relocation test I was using to trigger the original problem. I'm running fstests now via the CI, but this seems solid. Hopefully this makes the relocation code a bit easier to understand. Thanks,

Josef

Josef Bacik (10):
btrfs: convert BUG_ON in btrfs_reloc_cow_block to proper error
handling
btrfs: remove the changed list for backref cache
btrfs: add a comment for new_bytenr in bacref_cache_node
btrfs: cleanup select_reloc_root
btrfs: remove clone_backref_node
btrfs: don't build backref tree for cowonly blocks
btrfs: do not handle non-shareable roots in backref cache
btrfs: simplify btrfs_backref_release_cache
btrfs: remove the ->lowest and ->leaves members from backref cache
btrfs: remove detached list from btrfs_backref_cache

 fs/btrfs/backref.c    | 105 +++++-------
 fs/btrfs/backref.h    |  16 +-
 fs/btrfs/relocation.c | 362 +++++++++++++++++-------------------------
 3 files changed, 192 insertions(+), 291 deletions(-)
Signature · 1 line
2.43.0