Skip to content

xfrm: Convert __xfrm4_dst_lookup() and its callers to dscp_t.

Guillaume Nault netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesIn review
  2. v16 patches 2 repliesSuperseded

Changes in v2 from the cover letter

* Rebase on top of ipsec-next. Now we don't convert the ->dst_lookup() callback handlers since they they don't have any "tos" parameter anymore. Therefore, the original patches 4, 5 and 6 are dropped and replaced with the new patch 4, which just converts the "tos" field in struct xfrm_dst_lookup_params.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xfrm: Convert xfrm_get_tos() to dscp_t.net/xfrm/xfrm_policy.c+3 -31 reply
2/4xfrm: Convert xfrm_bundle_create() to dscp_t.net/xfrm/xfrm_policy.c+4 -31 reply
3/4xfrm: Convert xfrm_dst_lookup() to dscp_t.net/xfrm/xfrm_policy.c+4 -51 reply
4/4xfrm: Convert struct xfrm_dst_lookup_params -> tos to dscp_t.include/net/xfrm.h net/ipv4/xfrm4_policy.c net/xfrm/xfrm_policy.c+5 -31 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIdo Schimmel
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH ipsec-next v2 0/4] xfrm: Convert __xfrm4_dst_lookup() and its callers to dscp_t.

This patch series continues to prepare users of ->flowi4_tos to a future conversion of this field (__u8 to dscp_t). This time, we convert __xfrm4_dst_lookup() and its call chain.

The objective is to eventually make all users of ->flowi4_tos use a dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding regressions where ECN bits are erroneously interpreted as DSCP bits.

Changes since v1:
* Rebase on top of ipsec-next. Now we don't convert the ->dst_lookup() callback handlers since they they don't have any "tos" parameter anymore. Therefore, the original patches 4, 5 and 6 are dropped and replaced with the new patch 4, which just converts the "tos" field in struct xfrm_dst_lookup_params.

Guillaume Nault (4):
xfrm: Convert xfrm_get_tos() to dscp_t.
xfrm: Convert xfrm_bundle_create() to dscp_t.
xfrm: Convert xfrm_dst_lookup() to dscp_t.
xfrm: Convert struct xfrm_dst_lookup_params -> tos to dscp_t.

 include/net/xfrm.h      |  3 ++-
 net/ipv4/xfrm4_policy.c |  3 ++-
 net/xfrm/xfrm_policy.c  | 16 ++++++++--------
 3 files changed, 12 insertions(+), 10 deletions(-)
Signature · 1 line
2.39.2