Skip to content

net: Avoid thousands of -Wflex-array-member-not-at-end warnings

Gustavo A. R. Silva linux-hardening linux-nfs linux-wireless lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: dev: Introduce struct sockaddr_legacyinclude/linux/socket.h+19 -04 replies
2/5nfsd: avoid -Wflex-array-member-not-at-end warningsfs/nfsd/nfsctl.c fs/nfsd/nfsd.h+4 -42 replies
3/5uapi: wireless: Avoid -Wflex-array-member-not-at-end warningsinclude/uapi/linux/wireless.h+25 -251 reply
4/5uapi: net: arp: Avoid -Wflex-array-member-not-at-end warningsinclude/uapi/linux/if_arp.h net/ipv4/arp.c+10 -104 replies
5/5uapi: net: Avoid -Wflex-array-member-not-at-end warningsinclude/net/compat.h include/uapi/linux/route.h net/appletalk/ddp.c +2 more+32 -321 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchKuniyuki Iwashima
1/5R-b
2/5
3/5
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5][next] net: Avoid thousands of -Wflex-array-member-not-at-end warnings

This series aims to resolve thousands of -Wflex-array-member-not-at-end warnings by introducing struct sockaddr_legacy. The intention is to use it to replace the type of several struct members in the middle of composite structures, currently of type struct sockaddr.

These middle struct members are currently causing thousands of warnings because struct sockaddr contains a flexible-array member, introduced by commit b5f0de6df6dce ("net: dev: Convert sa_data to flexible array in struct sockaddR").

The new struct sockaddr_legacy doesn't include a flexible-array member, making it suitable for use as the type of middle members in composite structs that don't really require the flexible-array member in struct sockaddr, thus avoiding -Wflex-array-member-not-at-end warnings.

Gustavo A. R. Silva (5):
net: dev: Introduce struct sockaddr_legacy
nfsd: avoid -Wflex-array-member-not-at-end warnings
uapi: wireless: Avoid -Wflex-array-member-not-at-end warnings
uapi: net: arp: Avoid -Wflex-array-member-not-at-end warnings
uapi: net: Avoid -Wflex-array-member-not-at-end warnings

 fs/nfsd/nfsctl.c              |  4 +--
 fs/nfsd/nfsd.h                |  4 +--
 include/linux/socket.h        | 19 +++++++++++++
 include/net/compat.h          | 30 ++++++++++-----------
 include/uapi/linux/if_arp.h   | 18 ++++++-------
 include/uapi/linux/route.h    | 28 ++++++++++----------
 include/uapi/linux/wireless.h | 50 +++++++++++++++++------------------
 net/appletalk/ddp.c           |  2 +-
 net/ipv4/af_inet.c            |  2 +-
 net/ipv4/arp.c                |  2 +-
 net/ipv4/fib_frontend.c       |  2 +-
 11 files changed, 90 insertions(+), 71 deletions(-)
Signature · 1 line
2.34.1