Skip to content

btrfs: convert delayed head refs to xarray and cleanups

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18btrfs: remove BUG_ON() at btrfs_destroy_delayed_refs()fs/btrfs/disk-io.c+24 -130 replies
2/18btrfs: move btrfs_destroy_delayed_refs() to delayed-ref.cfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/disk-io.c+83 -800 replies
3/18btrfs: remove fs_info parameter from btrfs_destroy_delayed_refs()fs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/disk-io.c+4 -50 replies
4/18btrfs: remove fs_info parameter from btrfs_cleanup_one_transaction()fs/btrfs/disk-io.c fs/btrfs/disk-io.h fs/btrfs/transaction.c+6 -70 replies
5/18btrfs: remove duplicated code to drop delayed ref during transaction abortfs/btrfs/delayed-ref.c+1 -70 replies
6/18btrfs: use helper to find first ref head at btrfs_destroy_delayed_refs()fs/btrfs/delayed-ref.c+5 -40 replies
7/18btrfs: remove num_entries atomic counter from delayed ref rootfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c +1 more+0 -110 replies
8/18btrfs: change return type of btrfs_delayed_ref_lock() to booleanfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c+11 -110 replies
9/18btrfs: simplify obtaining a delayed ref headfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c+23 -410 replies
10/18btrfs: move delayed ref head unselection to delayed-ref.cfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c+15 -130 replies
11/18btrfs: pass fs_info to functions that search for delayed ref headsfs/btrfs/backref.c fs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h +1 more+18 -110 replies
12/18btrfs: pass fs_info to btrfs_cleanup_ref_head_accountingfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c+10 -70 replies
13/18btrfs: assert delayed refs lock is held at find_ref_head()fs/btrfs/delayed-ref.c+2 -20 replies
14/18btrfs: assert delayed refs lock is held at find_first_ref_head()fs/btrfs/delayed-ref.c+2 -00 replies
15/18btrfs: assert delayed refs lock is held at add_delayed_ref_head()fs/btrfs/delayed-ref.c+1 -00 replies
16/18btrfs: add comments regarding locking to struct btrfs_delayed_ref_rootfs/btrfs/delayed-ref.h+17 -30 replies
17/18btrfs: track delayed ref heads in an xarrayfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c +1 more+106 -1193 replies
18/18btrfs: remove no longer used delayed ref head search functionalityfs/btrfs/delayed-ref.c+5 -290 replies

Reviews trailers per patch

None of the 18 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris BurkovDavid SterbaQu Wenruo
SeriesR-b R-b R-b
1/18
2/18
3/18
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/18] btrfs: convert delayed head refs to xarray and cleanups

From: Filipe Manana <[email protected]>

This converts the rb-tree that tracks delayed ref heads into an xarray, reducing memory used by delayed ref heads and making it more efficient to add/remove/find delayed ref heads. The rest are mostly cleanups and refactorings, removing some dead code, deduplicating code, move code around, etc. More details in the changelogs.

Filipe Manana (18):
btrfs: remove BUG_ON() at btrfs_destroy_delayed_refs()
btrfs: move btrfs_destroy_delayed_refs() to delayed-ref.c
btrfs: remove fs_info parameter from btrfs_destroy_delayed_refs()
btrfs: remove fs_info parameter from btrfs_cleanup_one_transaction()
btrfs: remove duplicated code to drop delayed ref during transaction abort
btrfs: use helper to find first ref head at btrfs_destroy_delayed_refs()
btrfs: remove num_entries atomic counter from delayed ref root
btrfs: change return type of btrfs_delayed_ref_lock() to boolean
btrfs: simplify obtaining a delayed ref head
btrfs: move delayed ref head unselection to delayed-ref.c
btrfs: pass fs_info to functions that search for delayed ref heads
btrfs: pass fs_info to btrfs_cleanup_ref_head_accounting
btrfs: assert delayed refs lock is held at find_ref_head()
btrfs: assert delayed refs lock is held at find_first_ref_head()
btrfs: assert delayed refs lock is held at add_delayed_ref_head()
btrfs: add comments regarding locking to struct btrfs_delayed_ref_root
btrfs: track delayed ref heads in an xarray
btrfs: remove no longer used delayed ref head search functionality

 fs/btrfs/backref.c     |   3 +-
 fs/btrfs/delayed-ref.c | 319 +++++++++++++++++++++++++----------------
 fs/btrfs/delayed-ref.h |  61 +++++---
 fs/btrfs/disk-io.c     |  79 +---------
 fs/btrfs/disk-io.h     |   3 +-
 fs/btrfs/extent-tree.c |  69 ++-------
 fs/btrfs/transaction.c |   8 +-
 7 files changed, 256 insertions(+), 286 deletions(-)
Signature · 1 line
2.43.0