Skip to content

Provide a new two step DMA mapping API

Leon Romanovsky kvm linux-block linux-doc linux-iommu linux-mm linux-nvme linux-pci linux-rdma lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18PCI/P2PDMA: refactor the p2pdma mapping helpersdrivers/iommu/dma-iommu.c drivers/pci/p2pdma.c include/linux/dma-map-ops.h +1 more+89 -883 replies
2/18dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.hdrivers/iommu/dma-iommu.c include/linux/dma-map-ops.h include/linux/pci-p2pdma.h +1 more+86 -842 replies
3/18iommu: generalize the batched sync after map interfacedrivers/iommu/iommu.c include/linux/iommu.h+33 -360 replies
4/18dma-mapping: Add check if IOVA can be usedinclude/linux/dma-mapping.h+33 -00 replies
5/18dma: Provide an interface to allow allocate IOVAdrivers/iommu/dma-iommu.c include/linux/dma-mapping.h+94 -05 replies
6/18iommu/dma: Factor out a iommu_dma_map_swiotlb helperdrivers/iommu/dma-iommu.c+41 -320 replies
7/18dma-mapping: Implement link/unlink ranges APIdrivers/iommu/dma-iommu.c include/linux/dma-map-ops.h include/linux/dma-mapping.h+287 -13 replies
8/18dma-mapping: add a dma_need_unmap helperinclude/linux/dma-mapping.h kernel/dma/mapping.c+25 -00 replies
9/18docs: core-api: document the IOVA-based APIDocumentation/core-api/dma-api.rst+70 -02 replies
10/18mm/hmm: let users to tag specific PFN with DMA mapped bitinclude/linux/hmm.h mm/hmm.c+35 -130 replies
11/18mm/hmm: provide generic DMA managing logicinclude/linux/hmm-dma.h include/linux/hmm.h mm/hmm.c+229 -00 replies
12/18RDMA/umem: Store ODP access mask information in PFNdrivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/odp.c +1 more+61 -910 replies
13/18RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page linkagedrivers/infiniband/core/umem_odp.c drivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/odp.c +2 more+69 -1080 replies
14/18RDMA/umem: Separate implicit ODP initialization from explicit ODPdrivers/infiniband/core/umem_odp.c+46 -450 replies
15/18vfio/mlx5: Explicitly use number of pages instead of allocated lengthdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h drivers/vfio/pci/mlx5/main.c+57 -410 replies
16/18vfio/mlx5: Rewrite create mkey flow to allow better code reusedrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h+90 -700 replies
17/18vfio/mlx5: Explicitly store page listdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h+13 -170 replies
18/18vfio/mlx5: Convert vfio to use DMA link APIdrivers/vfio/pci/mlx5/cmd.c drivers/vfio/pci/mlx5/cmd.h drivers/vfio/pci/mlx5/main.c+114 -1370 replies

Reviews trailers per patch

2 of 18 patches have a Reviewed-by or Acked-by.

PatchLogan GunthorpeBjorn Helgaas
1/18R-b A-b
2/18R-b A-b
3/18
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] Provide a new two step DMA mapping API

Currently the only efficient way to map a complex memory description through the DMA API is by using the scatterlist APIs. The SG APIs are unique in that they efficiently combine the two fundamental operations of sizing and allocating a large IOVA window from the IOMMU and processing all the per-address swiotlb/flushing/p2p/map details.

This uniqueness has been a long standing pain point as the scatterlist API is mandatory, but expensive to use. It prevents any kind of optimization or feature improvement (such as avoiding struct page for P2P) due to the impossibility of improving the scatterlist.

Several approaches have been explored to expand the DMA API with additional scatterlist-like structures (BIO[1], rlist[2]), instead split up the DMA API to allow callers to bring their own data structure.

The API is split up into parts:
- Allocate IOVA space:
To do any pre-allocation required. This is done based on the caller supplying some details about how much IOMMU address space it would need in worst case.
- Map and unmap relevant structures to pre-allocated IOVA space:
Perform the actual mapping into the pre-allocated IOVA. This is very similar to dma_map_page().

In this and the next series [1], examples of three different users are converted to the new API to show the benefits and its versatility. Each user has a unique flow:
1. RDMA ODP is an example of "SVA mirroring" using HMM that needs to dynamically map/unmap large numbers of single pages. This becomes significantly faster in the IOMMU case as the map/unmap is now just a page table walk, the IOVA allocation is pre-computed once. Significant amounts of memory are saved as there is no longer a need to store the dma_addr_t of each page.
2. VFIO PCI live migration code is building a very large "page list" for the device. Instead of allocating a scatter list entry per allocated page it can just allocate an array of 'struct page *', saving a large amount of memory.
3. NVMe PCI demonstrates how a BIO can be converted to a HW scatter list without having to allocate then populate an intermediate SG table.

To make the use of the new API easier, HMM and block subsystems are extended to hide the optimization details from the caller. Among these optimizations:
* Memory reduction as in most real use cases there is no need to store mapped DMA addresses and unmap them.
* Reducing the function call overhead by removing the need to call function pointers and use direct calls instead.

This step is first along a path to provide alternatives to scatterlist and solve some of the abuses and design mistakes, for instance in DMABUF's P2P support.

Thanks

[1] https://lore.kernel.org/all/[email protected]

Christoph Hellwig (6):
PCI/P2PDMA: refactor the p2pdma mapping helpers
dma-mapping: move the PCI P2PDMA mapping helpers to pci-p2pdma.h
iommu: generalize the batched sync after map interface iommu/dma: Factor out a iommu_dma_map_swiotlb helper
dma-mapping: add a dma_need_unmap helper
docs: core-api: document the IOVA-based API

Leon Romanovsky (12):
dma-mapping: Add check if IOVA can be used
dma: Provide an interface to allow allocate IOVA
dma-mapping: Implement link/unlink ranges API
mm/hmm: let users to tag specific PFN with DMA mapped bit mm/hmm: provide generic DMA managing logic
RDMA/umem: Store ODP access mask information in PFN RDMA/core: Convert UMEM ODP DMA mapping to caching IOVA and page
linkage
RDMA/umem: Separate implicit ODP initialization from explicit ODP vfio/mlx5: Explicitly use number of pages instead of allocated length vfio/mlx5: Rewrite create mkey flow to allow better code reuse vfio/mlx5: Explicitly store page list
vfio/mlx5: Convert vfio to use DMA link API

 Documentation/core-api/dma-api.rst   |  70 +++++
 drivers/infiniband/core/umem_odp.c   | 250 +++++----------
 drivers/infiniband/hw/mlx5/mlx5_ib.h |  12 +-
 drivers/infiniband/hw/mlx5/odp.c     |  65 ++--
 drivers/infiniband/hw/mlx5/umr.c     |  12 +-
 drivers/iommu/dma-iommu.c            | 455 +++++++++++++++++++++++----
 drivers/iommu/iommu.c                |  65 ++--
 drivers/pci/p2pdma.c                 |  38 +--
 drivers/vfio/pci/mlx5/cmd.c          | 312 +++++++++---------
 drivers/vfio/pci/mlx5/cmd.h          |  24 +-
 drivers/vfio/pci/mlx5/main.c         |  87 +++--
 include/linux/dma-map-ops.h          |  54 ----
 include/linux/dma-mapping.h          |  84 +++++
 include/linux/hmm-dma.h              |  32 ++
 include/linux/hmm.h                  |  16 +
 include/linux/iommu.h                |   4 +
 include/linux/pci-p2pdma.h           |  84 +++++
 include/rdma/ib_umem_odp.h           |  25 +-
 kernel/dma/direct.c                  |  43 ++-
 kernel/dma/mapping.c                 |  20 ++
 mm/hmm.c                             | 229 +++++++++++++-
 21 files changed, 1345 insertions(+), 636 deletions(-)
 create mode 100644 include/linux/hmm-dma.h
Signature · 1 line
2.46.2