Skip to content

staging: rtl8723bs: Replace function pointers and #if 1

Philipp Hortmann linux-staging lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13staging: rtl8723bs: Replace function thread_enterdrivers/staging/rtl8723bs/core/rtw_cmd.c drivers/staging/rtl8723bs/core/rtw_xmit.c drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +1 more+3 -100 replies
2/13staging: rtl8723bs: Remove #if 1 in function hal_EfusePartialWriteCheckdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -530 replies
3/13staging: rtl8723bs: Remove #if 1 in function hal_EfuseGetCurrentSize_BTdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+0 -280 replies
4/13staging: rtl8723bs: Remove #if 1 in function ReadChipVersion8723Bdrivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c+2 -20 replies
5/13staging: rtl8723bs: Remove function pointer check_ips_statusdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -80 replies
6/13staging: rtl8723bs: Remove function pointer SetHwRegHandlerdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c drivers/staging/rtl8723bs/core/rtw_wlan_util.c drivers/staging/rtl8723bs/hal/hal_intf.c +2 more+7 -90 replies
7/13staging: rtl8723bs: Remove function pointer GetHwRegHandlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -60 replies
8/13staging: rtl8723bs: Remove function pointer SetHwRegHandlerWithBufdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -70 replies
9/13staging: rtl8723bs: Remove function pointer GetHalDefVarHandlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -60 replies
10/13staging: rtl8723bs: Remove function pointer SetHalDefVarHandlerdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+3 -90 replies
11/13staging: rtl8723bs: Remove function pointer hal_xmitdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -60 replies
12/13staging: rtl8723bs: Remove function pointer mgnt_xmitdrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -100 replies
13/13staging: rtl8723bs: Remove function pointer hal_xmitframe_enqueuedrivers/staging/rtl8723bs/hal/hal_intf.c drivers/staging/rtl8723bs/hal/sdio_halinit.c drivers/staging/rtl8723bs/include/hal_intf.h+1 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] staging: rtl8723bs: Replace function pointers and #if 1

Replace function pointers with functions to increase readability. Remove dead code resulting from #if 1.
Replace one function that just contains one line to increase readability.

Tested with rtl8723bs in ODYS Trendbook Next 14

Philipp Hortmann (13):
staging: rtl8723bs: Replace function thread_enter
staging: rtl8723bs: Remove #if 1 in function
hal_EfusePartialWriteCheck
staging: rtl8723bs: Remove #if 1 in function
hal_EfuseGetCurrentSize_BT
staging: rtl8723bs: Remove #if 1 in function ReadChipVersion8723B
staging: rtl8723bs: Remove function pointer check_ips_status
staging: rtl8723bs: Remove function pointer SetHwRegHandler
staging: rtl8723bs: Remove function pointer GetHwRegHandler
staging: rtl8723bs: Remove function pointer SetHwRegHandlerWithBuf
staging: rtl8723bs: Remove function pointer GetHalDefVarHandler
staging: rtl8723bs: Remove function pointer SetHalDefVarHandler
staging: rtl8723bs: Remove function pointer hal_xmit
staging: rtl8723bs: Remove function pointer mgnt_xmit
staging: rtl8723bs: Remove function pointer hal_xmitframe_enqueue

 drivers/staging/rtl8723bs/core/rtw_cmd.c      |  2 +-
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
 .../staging/rtl8723bs/core/rtw_wlan_util.c    |  4 +-
 drivers/staging/rtl8723bs/core/rtw_xmit.c     |  2 +-
 drivers/staging/rtl8723bs/hal/hal_intf.c      | 40 ++-------
 .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 85 +------------------
 .../staging/rtl8723bs/hal/rtl8723bs_xmit.c    |  4 +-
 drivers/staging/rtl8723bs/hal/sdio_halinit.c  | 21 ++---
 drivers/staging/rtl8723bs/include/hal_intf.h  | 22 ++---
 .../staging/rtl8723bs/include/osdep_service.h |  5 --
 10 files changed, 27 insertions(+), 160 deletions(-)
Signature · 1 line
2.43.0