Skip to content

btrfs: add a delayed ref self test

Josef Bacik linux-btrfs llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: move select_delayed_ref and export itfs/btrfs/delayed-ref.c fs/btrfs/delayed-ref.h fs/btrfs/extent-tree.c+30 -250 replies
2/2btrfs: add delayed ref self testsfs/btrfs/Makefile fs/btrfs/delayed-ref.c fs/btrfs/tests/btrfs-tests.c +2 more+1048 -46 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Burkov
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: add a delayed ref self test

Hello,

I made a silly mistake when refactoring the delayed ref code to make it easier to understand, and that resulted in a whole lot of not fun trying to find what went wrong with boxes started falling over when we were deploying 6.11. This style of bug is easy to catch with basic unit testing, so add a variety of unit tests for delayed refs to make sure I don't break things again. One patch moves an important helper and exports it so that we can do the testing, the other patch is a giant patch of all the tests with a few changes that are necessary to make everything work. I validated these work properly and catch a variety of bugs that I hand introduced to the delayed ref code. Thanks,

Josef Bacik (2):
btrfs: move select_delayed_ref and export it
btrfs: add delayed ref self tests

 fs/btrfs/Makefile                   |    2 +-
 fs/btrfs/delayed-ref.c              |   41 +-
 fs/btrfs/delayed-ref.h              |    2 +
 fs/btrfs/extent-tree.c              |   26 +-
 fs/btrfs/tests/btrfs-tests.c        |   18 +
 fs/btrfs/tests/btrfs-tests.h        |    6 +
 fs/btrfs/tests/delayed-refs-tests.c | 1012 +++++++++++++++++++++++++++
 7 files changed, 1078 insertions(+), 29 deletions(-)
 create mode 100644 fs/btrfs/tests/delayed-refs-tests.c
Signature · 1 line
2.43.0