Skip to content

btrfs: extra debug output for sector size < page size cases

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: subpage: fix the bitmap dump for the locked flagsfs/btrfs/subpage.c+4 -20 replies
2/3btrfs: subpage: dump the involved bitmap when ASSERT() failedfs/btrfs/subpage.c+30 -111 reply
3/3btrfs: add extra error messages for extent_writepage() failurefs/btrfs/extent_io.c+16 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDavid Sterba
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: extra debug output for sector size < page size cases

The first patch is the long existing bug that full subpage bitmap dump is not working for checked bitmap.
Thankfully even myself is not affected by the bug.

The second one is for a crash I hit where ASSERT() got triggered in btrfs_folio_set_locked() after a btrfs_run_delalloc_range() failure.

The last one is for the btrfs_run_delalloc_range() failure, which is not that rare in my environment, I guess the unsafe cache mode for my aarch64 VM makes it too easy to hit ENOSPC.

But ENOSPC from btrfs_run_delalloc_range() itself is already a problem for our data/metadata space reservation code, thus it should be outputted even for non-debug build.

Qu Wenruo (3):
btrfs: subpage: fix the bitmap dump for the locked flags
btrfs: subpage: dump the involved bitmap when ASSERT() failed
btrfs: add extra error messages for extent_writepage() failure

 fs/btrfs/extent_io.c | 16 +++++++++++++++
 fs/btrfs/subpage.c   | 47 ++++++++++++++++++++++++++++++++------------
 2 files changed, 50 insertions(+), 13 deletions(-)
Signature · 1 line
2.47.0