Skip to content

tools: ynl: add install target

Jan Stancek lkml netdev 4 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 2 repliesApplied 4/4
  2. v34 patches 7 repliesSuperseded
  3. v25 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches3 repliesSuperseded

Changes in v4 from the cover letter

- 1/4 tools: ynl: move python code to separate sub-directory no code changes, added Reviewed-by tag from v3
- 2/4 tools: ynl: add initial pyproject.toml for packaging no longer installs ynl-gen-c and ynl-gen-rst updated commit message
- 3/4 tools: ynl: add install target for generated content fixed mix of tabs and spaces in Makefile factored out SPECS_DIR so the path is not repeated fixed TOOL2->TOOL_RST
moved clear of .rst to distclean
- 4/4 tools: ynl: add main install target
no code changes, added Reviewed-by tags from v3

Patches in v4 All 4 applied

#Subject and filesSizeRepliesApplied
1/4tools: ynl: move python code to separate sub-directoryDocumentation/Makefile Documentation/networking/multi-pf-netdev.rst Documentation/networking/napi.rst +18 more+20 -170 repliesApplied
2/4tools: ynl: add initial pyproject.toml for packagingtools/net/ynl/pyproject.toml+24 -01 replyApplied
3/4tools: ynl: add install target for generated contenttools/net/ynl/generated/.gitignore tools/net/ynl/generated/Makefile+43 -71 replyApplied
4/4tools: ynl: add main install targettools/net/ynl/Makefile+26 -10 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDonald HunterJoe Damato
1/4R-b
2/4R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/4] tools: ynl: add install target

This series adds an install target for ynl. The python code is moved to a subdirectory, so it can be used as a package with flat layout, as well as directly from the tree.

To try the install as a non-root user you can run:

  $ mkdir /tmp/myroot
  $ make DESTDIR=/tmp/myroot install
  $ PATH="/tmp/myroot/usr/bin:$PATH" PYTHONPATH="$(ls -1d /tmp/myroot/usr/lib/python*/site-packages)" ynl --help

Proposed install layout is described in last patch.

Changes in v4:
- 1/4 tools: ynl: move python code to separate sub-directory no code changes, added Reviewed-by tag from v3
- 2/4 tools: ynl: add initial pyproject.toml for packaging no longer installs ynl-gen-c and ynl-gen-rst updated commit message
- 3/4 tools: ynl: add install target for generated content fixed mix of tabs and spaces in Makefile factored out SPECS_DIR so the path is not repeated fixed TOOL2->TOOL_RST
moved clear of .rst to distclean
- 4/4 tools: ynl: add main install target
no code changes, added Reviewed-by tags from v3

Changes in v3:
- dropped symlinks
- added install-headers install-rsts install-specs to PHONY target in generated/Makefile
- install headers from lib and generated directories to /usr/include/ynl

Changes in v2:
- squashed 1st and 2nd patch together
- added symlinks for original user-facing scripts for backwards compatibility
- updated also Documentation and selftests references
(tested Doc build and selftests ping.py test)

Jan Stancek (4):
tools: ynl: move python code to separate sub-directory
tools: ynl: add initial pyproject.toml for packaging
tools: ynl: add install target for generated content
tools: ynl: add main install target

 Documentation/Makefile                        |  2 +-
 Documentation/networking/multi-pf-netdev.rst  |  4 +-
 Documentation/networking/napi.rst             |  4 +-
 .../networking/netlink_spec/readme.txt        |  2 +-
 .../userspace-api/netlink/intro-specs.rst     |  8 +--
 tools/net/ynl/Makefile                        | 29 ++++++++++-
 tools/net/ynl/generated/.gitignore            |  1 +
 tools/net/ynl/generated/Makefile              | 51 ++++++++++++++++---
 tools/net/ynl/lib/.gitignore                  |  1 -
 tools/net/ynl/lib/Makefile                    |  1 -
 tools/net/ynl/pyproject.toml                  | 24 +++++++++
 tools/net/ynl/pyynl/.gitignore                |  2 +
 tools/net/ynl/pyynl/__init__.py               |  0
 tools/net/ynl/{ => pyynl}/cli.py              |  0
 tools/net/ynl/{ => pyynl}/ethtool.py          |  0
 tools/net/ynl/{ => pyynl}/lib/__init__.py     |  0
 tools/net/ynl/{ => pyynl}/lib/nlspec.py       |  0
 tools/net/ynl/{ => pyynl}/lib/ynl.py          |  0
 .../ynl/{ynl-gen-c.py => pyynl/ynl_gen_c.py}  |  0
 .../{ynl-gen-rst.py => pyynl/ynl_gen_rst.py}  |  0
 tools/net/ynl/ynl-regen.sh                    |  2 +-
 tools/testing/selftests/net/lib/py/ynl.py     |  4 +-
 tools/testing/selftests/net/ynl.mk            |  3 +-
 23 files changed, 113 insertions(+), 25 deletions(-)
 create mode 100644 tools/net/ynl/pyproject.toml
 create mode 100644 tools/net/ynl/pyynl/.gitignore
 create mode 100644 tools/net/ynl/pyynl/__init__.py
 rename tools/net/ynl/{ => pyynl}/cli.py (100%)
 rename tools/net/ynl/{ => pyynl}/ethtool.py (100%)
 rename tools/net/ynl/{ => pyynl}/lib/__init__.py (100%)
 rename tools/net/ynl/{ => pyynl}/lib/nlspec.py (100%)
 rename tools/net/ynl/{ => pyynl}/lib/ynl.py (100%)
 rename tools/net/ynl/{ynl-gen-c.py => pyynl/ynl_gen_c.py} (100%)
 rename tools/net/ynl/{ynl-gen-rst.py => pyynl/ynl_gen_rst.py} (100%)
Signature · 1 line
2.43.0