Skip to content

Prepare GHES driver to support error injection

Mauro Carvalho Chehab kvm lkml qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest31 patches 9 repliesIn review

v5 from the cover letter

- some changes at patches description and added some R-B;
- no changes at the code.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVEDhw/acpi/ghes.c include/hw/acpi/ghes.h+4 -60 replies
2/31acpi/ghes: simplify acpi_ghes_record_errors() codehw/acpi/ghes.c+29 -270 replies
3/31acpi/ghes: simplify the per-arch caller to build HEST tablehw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+9 -70 replies
4/31acpi/ghes: better handle source_id and notificationhw/acpi/ghes.c+9 -140 replies
5/31acpi/ghes: Fix acpi_ghes_record_errors() argumentinclude/hw/acpi/ghes.h+1 -10 replies
6/31acpi/ghes: Remove a duplicated out of bounds checkhw/acpi/ghes.c+1 -30 replies
7/31acpi/ghes: Change the type for source_idhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h+3 -30 replies
8/31acpi/ghes: don't check if physical_address is not zerohw/acpi/ghes.c+0 -40 replies
9/31acpi/ghes: make the GHES record generation more generichw/acpi/ghes.c include/hw/acpi/ghes.h+73 -510 replies
10/31acpi/ghes: better name GHES memory error functionhw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h +1 more+5 -50 replies
11/31acpi/ghes: don't crash QEMU if ghes GED is not foundhw/acpi/ghes.c+4 -10 replies
12/31acpi/ghes: rename etc/hardware_error file macroshw/acpi/ghes.c+23 -150 replies
13/31acpi/ghes: better name the offset of the hardware error firmwarehw/acpi/generic_event_device.c hw/acpi/ghes.c include/hw/acpi/ghes.h+5 -50 replies
14/31acpi/ghes: Prepare to support multiple sources on gheshw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+47 -220 replies
15/31acpi/ghes: add a firmware file with HEST addresshw/acpi/ghes.c include/hw/acpi/ghes.h+17 -10 replies
16/31acpi/ghes: Use HEST table offsets when preparing GHES recordshw/acpi/ghes.c+96 -100 replies
17/31acpi/generic_event_device: Update GHES migration to cover hest addrhw/acpi/generic_event_device.c+29 -00 replies
18/31acpi/generic_event_device: add logic to detect if HEST addr is availablehw/acpi/generic_event_device.c hw/acpi/ghes.c hw/arm/virt-acpi-build.c +2 more+47 -110 replies
19/31acpi/ghes: add a notifier to notify when error data is readyhw/acpi/ghes.c include/hw/acpi/ghes.h+7 -10 replies
20/31acpi/generic_event_device: add an APEI error devicehw/acpi/aml-build.c hw/acpi/generic_event_device.c include/hw/acpi/acpi_dev_interface.h +2 more+22 -00 replies
21/31arm/virt: Wire up a GED error device for ACPI / GHEShw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+13 -10 replies
22/31qapi/acpi-hest: add an interface to do generic CPER error injectionMAINTAINERS hw/acpi/Kconfig hw/acpi/ghes.c +10 more+113 -10 replies
23/31scripts/ghes_inject: add a script to generate GHES error injectMAINTAINERS scripts/arm_processor_error.py scripts/ghes_inject.py +1 more+1133 -00 replies
24/31target/arm: add an experimental mpidr arm cpu property objecttarget/arm/cpu.c target/arm/cpu.h target/arm/helper.c+10 -20 replies
25/31scripts/arm_processor_error.py: retrieve mpidr if not filledscripts/arm_processor_error.py+21 -80 replies
26/31acpi/ghes: move offset calculus to a separate functionhw/acpi/ghes.c+31 -90 replies
27/31DEBUGhw/acpi/ghes.c+2 -03 replies
28/31acpi/ghes: Change ghes fill logic to work with only one sourcehw/acpi/ghes.c+4 -80 replies
29/31HACK: use GPIO as source ID for virt-9.1 machineshw/arm/virt-acpi-build.c+1 -10 replies
30/31docs: acpi_hest_ghes: fix documentation for CPER sizedocs/specs/acpi_hest_ghes.rst+4 -20 replies
31/31FIXME: acpi/ghes: properly set data record sizehw/acpi/ghes.c+7 -102 replies

Reviews trailers per patch

23 of 31 patches have a Reviewed-by or Acked-by.

PatchIgor MammedovJonathan CameronMauro Carvalho ChehabShiju Jose
1/31R-b R-b
2/31R-b R-b
3/31R-b R-b
4/31R-b R-b
5/31R-b R-b
6/31R-b R-b
7/31R-b R-b
8/31R-b
9/31R-b R-b
10/31R-b R-b
11/31R-b R-b
12/31R-b R-b
13/31R-b R-b
14/31R-b
15/31R-b
16/31R-b
17/31R-b
18/31R-b
19/31
20/31R-b Co-authored-by Co-authored-by
21/31A-b Co-authored-by Co-authored-by
22/31Co-authored-by Co-authored-by Co-authored-by
23/31
24/31
25/31
26/31R-b R-b
27/31
28/31R-b R-b
29/31
30/31R-b R-b
31/31

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/31] Prepare GHES driver to support error injection

Hi Michael,

Could you please merge this series for ACPI stuff? All patches were already reviewed by Igor. The changes against v4 are just on some patch descriptions, plus the addition of Reviewed-by. No Code changes.

Thanks,
Mauro

-

During the development of a patch series meant to allow GHESv2 error injections, it was requested a change on how CPER offsets are calculated, by adding a new BIOS pointer and reworking the GHES logic. See:

https://lore.kernel.org/qemu-devel/[email protected]/

Such change ended being a big patch, so several intermediate steps are needed, together with several cleanups and renames.

As agreed duing v10 review, I'll be splitting the big patch series into separate pull requests, starting with the cleanup series. This is the first patch set, containing only such preparation patches.

The next series will contain the shift to use offsets from the location of the HEST table, together with a migration logic to make it compatible with 9.1.

---

v5:
- some changes at patches description and added some R-B;
- no changes at the code.

v4:
- merged a patch renaming the function which calculate offsets to:
get_hw_error_offsets(), to avoid the need of such change at the next patch series;
- removed a functional change at the logic which makes
the GHES record generation more generic;
- a couple of trivial changes on patch descriptions and line break cleanups.

v3:
- improved some patch descriptions;
- some patches got reordered to better reflect the changes;
- patch v2 08/15: acpi/ghes: Prepare to support multiple sources on ghes was split on two patches. The first one is in this cleanup series:
acpi/ghes: Change ghes fill logic to work with only one source
contains just the simplification logic. The actual preparation will be moved to this series:

     https://lore.kernel.org/qemu-devel/[email protected]/

v2:
- some indentation fixes;
- some description improvements;
- fixed a badly-solved merge conflict that ended renaming a parameter.

Mauro Carvalho Chehab (31):
acpi/ghes: get rid of ACPI_HEST_SRC_ID_RESERVED acpi/ghes: simplify acpi_ghes_record_errors() code acpi/ghes: simplify the per-arch caller to build HEST table acpi/ghes: better handle source_id and notification acpi/ghes: Fix acpi_ghes_record_errors() argument acpi/ghes: Remove a duplicated out of bounds check acpi/ghes: Change the type for source_id
acpi/ghes: don't check if physical_address is not zero acpi/ghes: make the GHES record generation more generic acpi/ghes: better name GHES memory error function acpi/ghes: don't crash QEMU if ghes GED is not found acpi/ghes: rename etc/hardware_error file macros acpi/ghes: better name the offset of the hardware error firmware acpi/ghes: Prepare to support multiple sources on ghes acpi/ghes: add a firmware file with HEST address acpi/ghes: Use HEST table offsets when preparing GHES records acpi/generic_event_device: Update GHES migration to cover hest addr acpi/generic_event_device: add logic to detect if HEST addr is
available
acpi/ghes: add a notifier to notify when error data is ready acpi/generic_event_device: add an APEI error device arm/virt: Wire up a GED error device for ACPI / GHES qapi/acpi-hest: add an interface to do generic CPER error injection scripts/ghes_inject: add a script to generate GHES error inject target/arm: add an experimental mpidr arm cpu property object scripts/arm_processor_error.py: retrieve mpidr if not filled acpi/ghes: move offset calculus to a separate function DEBUG
acpi/ghes: Change ghes fill logic to work with only one source
HACK: use GPIO as source ID for virt-9.1 machines
docs: acpi_hest_ghes: fix documentation for CPER size
FIXME: acpi/ghes: properly set data record size

 MAINTAINERS                            |  10 +
 docs/specs/acpi_hest_ghes.rst          |   6 +-
 hw/acpi/Kconfig                        |   5 +
 hw/acpi/aml-build.c                    |  10 +
 hw/acpi/generic_event_device.c         |  42 +-
 hw/acpi/ghes-stub.c                    |   2 +-
 hw/acpi/ghes.c                         | 391 ++++++++++----
 hw/acpi/ghes_cper.c                    |  32 ++
 hw/acpi/ghes_cper_stub.c               |  19 +
 hw/acpi/meson.build                    |   2 +
 hw/arm/virt-acpi-build.c               |  36 +-
 hw/arm/virt.c                          |  19 +-
 hw/core/machine.c                      |   2 +
 include/hw/acpi/acpi_dev_interface.h   |   1 +
 include/hw/acpi/aml-build.h            |   2 +
 include/hw/acpi/generic_event_device.h |   1 +
 include/hw/acpi/ghes.h                 |  39 +-
 include/hw/arm/virt.h                  |   2 +
 qapi/acpi-hest.json                    |  35 ++
 qapi/meson.build                       |   1 +
 qapi/qapi-schema.json                  |   1 +
 scripts/arm_processor_error.py         | 390 ++++++++++++++
 scripts/ghes_inject.py                 |  51 ++
 scripts/qmp_helper.py                  | 702 +++++++++++++++++++++++++
 target/arm/cpu.c                       |   1 +
 target/arm/cpu.h                       |   1 +
 target/arm/helper.c                    |  10 +-
 target/arm/kvm.c                       |   2 +-
 28 files changed, 1678 insertions(+), 137 deletions(-)
 create mode 100644 hw/acpi/ghes_cper.c
 create mode 100644 hw/acpi/ghes_cper_stub.c
 create mode 100644 qapi/acpi-hest.json
 create mode 100644 scripts/arm_processor_error.py
 create mode 100755 scripts/ghes_inject.py
 create mode 100644 scripts/qmp_helper.py
Signature · 1 line
2.47.1