Skip to content

BPF path manager, part 2

Geliang Tang mptcp 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 5 repliesIn review
  2. v38 patches 6 repliesSuperseded
  3. v28 patches 7 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches1 replySuperseded

Changes in v4 from the cover letter

- move "mptcp: userspace pm set_flags id support" out of this set.
- only add 'local' parameter for set_flags, no 'remote'.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7mptcp: make three pm wrappers staticnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/protocol.h+20 -220 replies
2/7mptcp: drop skb parameter of get_addrnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+8 -100 replies
3/7mptcp: add id parameter for get_addrnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+24 -280 replies
4/7mptcp: reuse sending nlmsg code in get_addrnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+50 -770 replies
5/7mptcp: drop skb parameter of set_flagsnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+9 -90 replies
6/7mptcp: change rem type of set_flagsnet/mptcp/pm_userspace.c+4 -40 replies
7/7mptcp: add local parameter for set_flagsnet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+38 -401 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMatthieu Baerts (NGI0)
SeriesR-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH mptcp-next v4 0/7] BPF path manager, part 2

From: Geliang Tang <[email protected]>

v4:
- move "mptcp: userspace pm set_flags id support" out of this set.
- only add 'local' parameter for set_flags, no 'remote'.

Based-on: <[email protected]>

v3:
- Thanks Matt for the review on dump_addr interfaces. It seems that
it needs more time to be modified. In this version, I removed the patches for dump_addr interfaces from this set and added the patches for set_flags interfaces.
- set_flags interfaces patches address Matt's comments on the set
"mptcp: use GENL_REQ_ATTR_CHECK in userspace pm" v2.

v2:
- split patch 7 of v1 into two.
- patches 1-6 have no code changes, only the commit logs have been
updated.
- more commit log to explain why mptcp_pm_addr_id_bitmap_t needs to
be defined.
- use mptcp_pm_addr_id_bitmap_t in userspace_pm_append_new_local_addr
too.

In order to implement BPF userspace path manager, it is necessary to unify the interfaces of the path manager. This set updates get_addr() and dump_addr() interfaces.

Geliang Tang (7):
mptcp: make three pm wrappers static
mptcp: drop skb parameter of get_addr
mptcp: add id parameter for get_addr
mptcp: reuse sending nlmsg code in get_addr
mptcp: drop skb parameter of set_flags
mptcp: change rem type of set_flags
mptcp: add local parameter for set_flags

 net/mptcp/pm.c           |  86 +++++++++++++++++++++++++++++---
 net/mptcp/pm_netlink.c   | 104 ++++++++-------------------------------
 net/mptcp/pm_userspace.c |  81 +++++++-----------------------
 net/mptcp/protocol.h     |  14 +++---
 4 files changed, 124 insertions(+), 161 deletions(-)
Signature · 1 line
2.45.2