Skip to content

btrfs: fixes around swap file activation and cleanups

[email protected] linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 5 repliesIn review
  2. v111 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11btrfs: fix race with memory mapped writes when activating swap filefs/btrfs/inode.c+24 -70 replies
2/11btrfs: fix swap file activation failure due to extents that used to be sharedfs/btrfs/inode.c+69 -272 replies
3/11btrfs: allow swap activation to be interruptiblefs/btrfs/inode.c+5 -00 replies
4/11btrfs: avoid monopolizing a core when activating a swap filefs/btrfs/inode.c+2 -00 replies
5/11btrfs: remove no longer needed strict argument from can_nocow_extent()fs/btrfs/btrfs_inode.h fs/btrfs/direct-io.c fs/btrfs/extent-tree.c +3 more+13 -220 replies
6/11btrfs: remove the snapshot check from check_committed_ref()fs/btrfs/extent-tree.c+0 -80 replies
7/11btrfs: avoid redundant call to get inline ref type at check_committed_ref()fs/btrfs/extent-tree.c+1 -10 replies
8/11btrfs: simplify return logic at check_committed_ref()fs/btrfs/extent-tree.c+9 -140 replies
9/11btrfs: simplify arguments for btrfs_cross_ref_exist()fs/btrfs/extent-tree.c fs/btrfs/extent-tree.h fs/btrfs/inode.c+14 -140 replies
10/11btrfs: add function comment for check_committed_ref()fs/btrfs/extent-tree.c+43 -00 replies
11/11btrfs: add assertions and comment about path expectations to btrfs_cross_ref_exist()fs/btrfs/extent-tree.c fs/btrfs/locking.h+30 -02 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchQu Wenruo
SeriesR-b
1/11
2/11R-b
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] btrfs: fixes around swap file activation and cleanups

From: Filipe Manana <[email protected]>

There are a couple issues with swap file activation, one being races with memory mapped writes, while the other one is a failure due to buggy detection of extent sharedness - we can often consider an extent as shared when it is not but it used to be. The rest are just some cleanups or enhancements.

V2: Updated patch 10/11, it mentioned a no longer existing argument that
removed in patch 05/11, the patches were re-ordered at some point.

Filipe Manana (11):
btrfs: fix race with memory mapped writes when activating swap file
btrfs: fix swap file activation failure due to extents that used to be shared
btrfs: allow swap activation to be interruptible
btrfs: avoid monopolizing a core when activating a swap file
btrfs: remove no longer needed strict argument from can_nocow_extent()
btrfs: remove the snapshot check from check_committed_ref()
btrfs: avoid redundant call to get inline ref type at check_committed_ref()
btrfs: simplify return logic at check_committed_ref()
btrfs: simplify arguments for btrfs_cross_ref_exist()
btrfs: add function comment for check_committed_ref()
btrfs: add assertions and comment about path expectations to btrfs_cross_ref_exist()

 fs/btrfs/btrfs_inode.h |   2 +-
 fs/btrfs/direct-io.c   |   3 +-
 fs/btrfs/extent-tree.c | 128 +++++++++++++++++++++++++-----------
 fs/btrfs/extent-tree.h |   3 +-
 fs/btrfs/file.c        |   2 +-
 fs/btrfs/inode.c       | 146 +++++++++++++++++++++++++++++------------
 fs/btrfs/locking.h     |   5 ++
 7 files changed, 203 insertions(+), 86 deletions(-)
Signature · 1 line
2.45.2