Skip to content

btrfs: remove plenty of redundant btrfs_mark_buffer_dirty() calls

[email protected] linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20btrfs: tree-log: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/tree-log.c+0 -40 replies
2/20btrfs: free-space-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/free-space-tree.c+0 -50 replies
3/20btrfs: extent-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/extent-tree.c+0 -100 replies
4/20btrfs: block-group: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/block-group.c+0 -20 replies
5/20btrfs: delayed-inode: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/delayed-inode.c+0 -10 replies
6/20btrfs: dev-replace: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/dev-replace.c+0 -30 replies
7/20btrfs: dir-item: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/dir-item.c+0 -20 replies
8/20btrfs: file: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/file.c+0 -110 replies
9/20btrfs: file-item: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/file-item.c+0 -30 replies
10/20btrfs: free-space-cache: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/free-space-cache.c+0 -30 replies
11/20btrfs: inode: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/inode.c+0 -50 replies
12/20btrfs: inode-item: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/inode-item.c+0 -50 replies
13/20btrfs: ioctl: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/ioctl.c+0 -10 replies
14/20btrfs: qgroup: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/qgroup.c+0 -180 replies
15/20btrfs: raid-stripe-tree: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/raid-stripe-tree.c+0 -10 replies
16/20btrfs: relocation: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/relocation.c+0 -70 replies
17/20btrfs: root-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/root-tree.c+0 -20 replies
18/20btrfs: uuid-tree: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/uuid-tree.c+0 -20 replies
19/20btrfs: volumes: remove unnecessary calls to btrfs_mark_buffer_dirty()fs/btrfs/volumes.c+1 -110 replies
20/20btrfs: xattr: remove unnecessary call to btrfs_mark_buffer_dirty()fs/btrfs/xattr.c+0 -10 replies

Reviews trailers per patch

None of the 20 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohannes Thumshirn
SeriesR-b
1/20
2/20
3/20
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] btrfs: remove plenty of redundant btrfs_mark_buffer_dirty() calls

From: Filipe Manana <[email protected]>

There's quite a lot of places calling btrfs_mark_buffer_dirty() when it is not necessary because we already have a path setup for writing, due to calls to btrfs_search_slot() with a 'cow' argument having a value of 1 or anything that calls btrfs_search_slot() that way (and it's obvious from the context). These make the code more verbose, add some overhead and increase the module's text size unnecessarily. This patchset removes such unnecessary calls. Often people keep adding them because they copy the approach done from such places.

The changes are made on a per file basis to make it easier to review or bisect.

Module size before this patchset:

  $ size fs/btrfs/btrfs.ko 
     text	   data	    bss	    dec	    hex	filename
  1781992	 161029	  16920	1959941	 1de805	fs/btrfs/btrfs.ko

After this patchet:

  $ size fs/btrfs/btrfs.ko 
     text	   data	    bss	    dec	    hex	filename
  1780646	 161021	  16920	1958587	 1de2bb	fs/btrfs/btrfs.ko

Filipe Manana (20):
btrfs: tree-log: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: free-space-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: extent-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: block-group: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: delayed-inode: remove unnecessary call to btrfs_mark_buffer_dirty()
btrfs: dev-replace: remove unnecessary call to btrfs_mark_buffer_dirty()
btrfs: dir-item: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: file: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: file-item: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: free-space-cache: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: inode: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: inode-item: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: ioctl: remove unnecessary call to btrfs_mark_buffer_dirty()
btrfs: qgroup: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: raid-stripe-tree: remove unnecessary call to btrfs_mark_buffer_dirty()
btrfs: relocation: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: root-tree: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: uuid-tree: remove unnecessary call to btrfs_mark_buffer_dirty()
btrfs: volumes: remove unnecessary calls to btrfs_mark_buffer_dirty()
btrfs: xattr: remove unnecessary call to btrfs_mark_buffer_dirty()

 fs/btrfs/block-group.c      |  2 --
 fs/btrfs/delayed-inode.c    |  1 -
 fs/btrfs/dev-replace.c      |  3 ---
 fs/btrfs/dir-item.c         |  2 --
 fs/btrfs/extent-tree.c      | 10 ----------
 fs/btrfs/file-item.c        |  3 ---
 fs/btrfs/file.c             | 11 -----------
 fs/btrfs/free-space-cache.c |  3 ---
 fs/btrfs/free-space-tree.c  |  5 -----
 fs/btrfs/inode-item.c       |  5 -----
 fs/btrfs/inode.c            |  5 -----
 fs/btrfs/ioctl.c            |  1 -
 fs/btrfs/qgroup.c           | 18 ------------------
 fs/btrfs/raid-stripe-tree.c |  1 -
 fs/btrfs/relocation.c       |  7 -------
 fs/btrfs/root-tree.c        |  2 --
 fs/btrfs/tree-log.c         |  4 ----
 fs/btrfs/uuid-tree.c        |  2 --
 fs/btrfs/volumes.c          | 12 +-----------
 fs/btrfs/xattr.c            |  1 -
 20 files changed, 1 insertion(+), 97 deletions(-)
Signature · 1 line
2.45.2