RFC x86: Trenchboot Secure Launch DRTM for AMD SKINIT (Linux)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest posting 2/29 patches 1 replyIn review
- v2 RFC posting 1/27 patches 0 repliesSuperseded
- v1 RFC7 patches 0 repliesSuperseded
Changes in v2 from the cover letter
- rebase onto v14 of the main patch set
- cleaner handling of reset in sl_main.c leading to a smaller diff
- renamed slr_entry_amd_info::boot_params_{base,addr} for consistency with slr_entry_intel_info
- slightly safer slaunch_reset() macro in slmodule.c
Patches in v2 posting 2/2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | Documentation/x86: update Secure Launch for AMD SKINITDocumentation/ Documentation/ | +113 | 0 replies | |
| 2/9 | x86: AMD changes for Secure Launch Resource Table header fileinclude/ | +15 | 0 replies | |
| 3/9 | x86: Secure Launch main header file AMD supportinclude/ | +70 | 0 replies | |
| 4/9 | x86: Split up Secure Launch setup and finalize functionsarch/ arch/ arch/ +1 more | +62 | 0 replies | |
| 5/9 | x86: Implement AMD support for Secure Launcharch/ arch/ arch/ +2 more | +347 | 0 replies | |
| 6/9 | x86: Prepare CPUs for post SKINIT launcharch/ arch/ arch/ | +41 | 0 replies | |
| 7/9 | x86/slmodule: Support AMD SKINITarch/ | +134 | 0 replies | |
| 8/9 | x86: AMD changes for EFI stub DRTM launch supportdrivers/ | +9 | 1 reply | |
| 9/9 | psp: Perform kernel portion of DRTM proceduresarch/ arch/ arch/ +1 more | +255 | 0 replies |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by.
| Patch | Ard Biesheuvel |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | A-b |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v2 0/9] x86: Trenchboot Secure Launch DRTM for AMD SKINIT (Linux)
NOTE: this patch set follows up on Intel TXT DRTM patches that are currently under review in their 14th version [0]; therefore, it is not standalone!
The publication of the patches at this point pursues several goals:
- Make anyone tracking upstream aware of the maturity of the support for AMD SKINIT.
- Collect early feedback on the SKINIT implementation.
- Finally, demonstrate the extensibility of Secure Launch for incorporating additional platforms.
As the RFC suggest, this series is temporal and will be updated based on changes made to the initial Secure Launch series. Review comments are greatly welcomed and will be worked/addressed, but we would caution that changes to the Secure Launch series will take precedence over review comments. Once the Secure Launch series is merged, this series will transition from RFC to a formally submitted series.
-----
The patches extend Secure Launch for legacy and UEFI boot with support for AMD CPUs and their DRTM in two flavours: SKINIT on its own and SKINIT with DRTM service running in PSP/ASP.
The code is adjusted to detect CPU type and handle AMD differently. DRTM-specific differences relative to Intel TXT include:
- absence of DRTM-specific registers to pass data from bootloader to DLME, resulting in passing some information via boot parameters
- use of a different SLRT entry
- not sending #INIT to APs
- special handling for TPM event logs to make them "compatible" with TXT logs
-----
[0]: https://lore.kernel.org/lkml/[email protected]/
Changes in v2:
- rebase onto v14 of the main patch set
- cleaner handling of reset in sl_main.c leading to a smaller diff
- renamed slr_entry_amd_info::boot_params_{base,addr} for consistency with slr_entry_intel_info
- slightly safer slaunch_reset() macro in slmodule.c
-----
Jagannathan Raman (1):
psp: Perform kernel portion of DRTM procedures
Michał Żygowski (1):
x86: Implement AMD support for Secure Launch
Ross Philipson (6):
x86: AMD changes for Secure Launch Resource Table header file
x86: Secure Launch main header file AMD support
x86: Split up Secure Launch setup and finalize functions
x86: Prepare CPUs for post SKINIT launch x86/slmodule: Support AMD SKINIT
x86: AMD changes for EFI stub DRTM launch support
Sergii Dmytruk (1):
Documentation/x86: update Secure Launch for AMD SKINIT
.../secure_launch_details.rst | 83 +++++- .../secure_launch_overview.rst | 61 ++-- arch/x86/Kconfig | 9 +- arch/x86/boot/compressed/sl_main.c | 271 ++++++++++++++---- arch/x86/boot/compressed/sl_stub.S | 41 ++- arch/x86/include/asm/svm.h | 2 + arch/x86/include/uapi/asm/setup_data.h | 3 +- arch/x86/kernel/Makefile | 1 + arch/x86/kernel/setup.c | 2 +- arch/x86/kernel/sl-psp.c | 239 +++++++++++++++ arch/x86/kernel/slaunch.c | 193 +++++++++++-- arch/x86/kernel/slmodule.c | 161 +++++++++-- arch/x86/kernel/smpboot.c | 15 +- arch/x86/kernel/traps.c | 4 + drivers/firmware/efi/libstub/x86-stub.c | 12 +- drivers/iommu/amd/init.c | 12 + include/linux/slaunch.h | 83 +++++- include/linux/slr_table.h | 15 + 18 files changed, 1044 insertions(+), 163 deletions(-) create mode 100644 arch/x86/kernel/sl-psp.c
base-commit: 616c6ae2fa0b736552873af08ad0e5532e04ad80
Signature · 1 line
2.49.0