Skip to content

ecdsa KEYCTL_PKEY_QUERY fixes

Lukas Wunner keyrings linux-crypto 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 3 repliesIn review
  2. v2 posting 1/24 patches 17 repliesSuperseded
  3. v13 patches 7 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: ecdsa - Fix enc/dec size reported by KEYCTL_PKEY_QUERYcrypto/asymmetric_keys/public_key.c+7 -21 reply
2/2crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERYcrypto/asymmetric_keys/public_key.c crypto/ecdsa-p1363.c crypto/ecdsa-x962.c +5 more+22 -141 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchStefan BergerIgnat Korchagin
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH RESEND v2 0/2] ecdsa KEYCTL_PKEY_QUERY fixes

Here are two patches for ecdsa to avoid reporting nonsensical values for enc/dec size and -- for P521 keys -- also the key size in response to KEYCTL_PKEY_QUERY system calls.

Resending as requested by Herbert:

https://lore.kernel.org/r/[email protected]/

Link to the original submission:

https://lore.kernel.org/r/[email protected]/

Although these are technically fixes, the issues they address are not critical, so I recommend not applying as fixes for v6.15, but rather let the patches soak in linux-next for v6.16.

Lukas Wunner (2):
crypto: ecdsa - Fix enc/dec size reported by KEYCTL_PKEY_QUERY
crypto: ecdsa - Fix NIST P521 key size reported by KEYCTL_PKEY_QUERY

 crypto/asymmetric_keys/public_key.c | 13 +++++++++----
 crypto/ecdsa-p1363.c                |  6 ++++--
 crypto/ecdsa-x962.c                 |  5 +++--
 crypto/ecdsa.c                      |  2 +-
 crypto/ecrdsa.c                     |  2 +-
 crypto/rsassa-pkcs1.c               |  2 +-
 crypto/sig.c                        |  9 +++++++--
 include/crypto/sig.h                |  2 +-
 8 files changed, 27 insertions(+), 14 deletions(-)
Signature · 1 line
2.43.0