Fix several bugs in error handling during device probe
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest5 patches 1 replyIn review
- v55 patches 2 repliesSuperseded
- v4 posting 2/25 patches 9 repliesSuperseded
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 posting 1/2 | 0 of 6 patches | 1 reply | Superseded | |
| v3 | 6 patches | 16 replies | Superseded | |
| v2 | 6 patches | 11 replies | Superseded | |
| v1 | 6 patches | 19 replies | Superseded |
Changes in v6 from the cover letter
1) fix coding style of patch 5
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drm/amdxcp: introduce new API amdgpu_xcp_drm_dev_free()drivers/ drivers/ | +54 | 0 replies | |
| 2/5 | drm/amdgpu: fix use after free bug related to amdgpu_driver_release_kms()drivers/ drivers/ drivers/ +1 more | +62 | 0 replies | |
| 3/5 | drm/amdgpu: fix invalid memory access in amdgpu_xcp_cfg_sysfs_fini()drivers/ | +1 | 0 replies | |
| 4/5 | drm/amdgpu: enhance error handling in function amdgpu_pci_probe()drivers/ | +9 | 0 replies | |
| 5/5 | drm/amdgpu: fix invalid memory access in amdgpu_fence_driver_sw_fini()drivers/ drivers/ | +26 | 1 reply |
Reviews trailers per patch
2 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Shuo Liu | Lijo Lazar | Mario Limonciello |
|---|---|---|---|
| 1/5 | |||
| 2/5 | T-b | R-b | R-b |
| 3/5 | |||
| 4/5 | R-b | ||
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [v6 0/5] Fix several bugs in error handling during device probe
This patchset tries to fix several memory leakages/invalid memory accesses on error handling path during GPU driver loading/unloading. They applies to:
https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
v6:
1) fix coding style of patch 5
v5:
1) drop first in v4, we have found a reliable way to fix the issue.
2) add patch 3 in v5 to fix a new issue
3) rework patch 5 according to review feedback
v4:
1) drop patch 1 in v3
2) split out amdxcp related change into a dedicated patch
3) use guard(mutex) instead of mutex_lock/unlock().
4) move patch 6 in v3 to next patch set
v3:
1) drop first patch of v2
2) rework the 0003/0004 patches of v2 according to review comments
3) add patch 0004 to fix possible resource leakage in amdgpu_pci_probe()
v2:
1) rebased to https://gitlab.freedesktop.org/agd5f/linux.git branch amd-staging-drm-next.
2) removed the first patch, which is unnecessary.
3) add amdgpu_xcp_drm_dev_free() in patch 0003 to enhance amdxcp driver to better support device remove and error handling.
4) reworked patch 0005 to fix it in amdgpu instead of drm core.
Jiang Liu (5):
drm/amdxcp: introduce new API amdgpu_xcp_drm_dev_free() drm/amdgpu: fix use after free bug related to
amdgpu_driver_release_kms()
drm/amdgpu: fix invalid memory access in amdgpu_xcp_cfg_sysfs_fini() drm/amdgpu: enhance error handling in function amdgpu_pci_probe() drm/amdgpu: fix invalid memory access in amdgpu_fence_driver_sw_fini()
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 33 ++++++++-- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 14 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 9 --- drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c | 71 +++++++++++++++++---- drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h | 3 +- drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c | 63 +++++++++++++++--- drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.h | 1 + 7 files changed, 152 insertions(+), 42 deletions(-)
Signature · 1 line
2.43.5