Skip to content

IB/mad: Add Flow Control for Solicited MADs

Leon Romanovsky linux-rdma lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Add separate send-only agent for REPs to prevent starvation of REPs when runnning both service and client on the same node.
* Instead of immediately resending a timed-out MAD, it will now be
* placed in backlog queue if the queue is not empty.
v1: https://lore.kernel.org/all/[email protected]
* Add a cancel state to the state machine which allows removing the
* status field in MAD's struct.
* Add change_mad_state function which handles all the state transition.
* Add WARN_ONs to check MAD states
* Reorganize patches to have only two patches in this series instead of
* three.
v0: https://lore.kernel.org/all/[email protected]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3IB/mad: Add state machine to MAD layerdrivers/infiniband/core/mad.c drivers/infiniband/core/mad_priv.h drivers/infiniband/core/mad_rmpp.c+250 -1200 replies
2/3IB/mad: Add flow control for solicited MADsdrivers/infiniband/core/mad.c drivers/infiniband/core/mad_priv.h+214 -100 replies
3/3IB/cm: Use separate agent w/o flow control for REPdrivers/infiniband/core/cm.c drivers/infiniband/core/mad.c+44 -100 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMaher SanallaSean Hefty
1/3
2/3
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH rdma-next v2 0/3] IB/mad: Add Flow Control for Solicited MADs

Changelog:
v2:
* Add separate send-only agent for REPs to prevent starvation of REPs when runnning both service and client on the same node.
* Instead of immediately resending a timed-out MAD, it will now be
* placed in backlog queue if the queue is not empty.
v1: https://lore.kernel.org/all/[email protected]
* Add a cancel state to the state machine which allows removing the
* status field in MAD's struct.
* Add change_mad_state function which handles all the state transition.
* Add WARN_ONs to check MAD states
* Reorganize patches to have only two patches in this series instead of
* three.
v0: https://lore.kernel.org/all/[email protected]

--------------------------------------------------------------------------
From Or and Vlad

This patch series introduces flow control for solicited MADs in the MAD layer, addressing the need to avoid loss caused by insufficient resources at the receiver side.

Both the client and the server act as receivers - the latter receives requests, while the former receives responses.
To facilitate this flow control, the series also refactors the MAD code, improving readability and enabling more straightforward implementation.

Patch #1: Add state machine to MAD layer
Patch #2: Add flow control for solicited MADs
Patch #3: Use separate send-only agent for REPs

The primary goal of this series is to add a flow control mechanism to the MAD layer, reducing the number of timeouts.
The accompanying refactoring simplifies state management, making the code more maintainable and supporting the new flow control logic effectively.

Thanks

Or Har-Toov (2):
IB/mad: Add state machine to MAD layer
IB/mad: Add flow control for solicited MADs

Vlad Dumitrescu (1):
IB/cm: Use separate agent w/o flow control for REP

 drivers/infiniband/core/cm.c       |  47 ++-
 drivers/infiniband/core/mad.c      | 468 ++++++++++++++++++++++-------
 drivers/infiniband/core/mad_priv.h |  76 ++++-
 drivers/infiniband/core/mad_rmpp.c |  41 +--
 4 files changed, 500 insertions(+), 132 deletions(-)
Signature · 1 line
2.50.0