Skip to content

BPF path manager, part 3

Geliang Tang mptcp 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 5 repliesIn review
  2. v47 patches 9 repliesSuperseded
  3. v36 patches 4 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches2 repliesSuperseded
v16 patches1 replySuperseded

Changes in v5 from the cover letter

- drop "change is_backup interfaces as get_flags"
- move "add struct mptcp_pm_addr_id_bitmap" and "hold msk lock before
removing id 0 address" out of this set.
- a new patch "use ipv6_addr_equal in addresses_equal"
- patch 4, drop inet6_sk() in mptcp_event_add_subflow() and mptcp_event_pm_listener() too.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mptcp: add a build check for userspace_pm_dump_addrnet/mptcp/pm_userspace.c+2 -00 replies
2/5mptcp: add mptcp_pm_genl_fill_addr helpernet/mptcp/pm.c net/mptcp/pm_netlink.c net/mptcp/pm_userspace.c +1 more+26 -221 reply
3/5mptcp: drop match in userspace_pm_append_new_local_addrnet/mptcp/pm_userspace.c+3 -80 replies
4/5mptcp: drop inet6_sk after inet_sknet/mptcp/pm_netlink.c net/mptcp/pm_userspace.c+3 -91 reply
5/5mptcp: use ipv6_addr_equal in addresses_equalnet/mptcp/pm_netlink.c+1 -11 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMatthieu Baerts (NGI0)
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH mptcp-next v5 0/5] BPF path manager, part 3

From: Geliang Tang <[email protected]>

v5:
- drop "change is_backup interfaces as get_flags"
- move "add struct mptcp_pm_addr_id_bitmap" and "hold msk lock before
removing id 0 address" out of this set.
- a new patch "use ipv6_addr_equal in addresses_equal"
- patch 4, drop inet6_sk() in mptcp_event_add_subflow() and mptcp_event_pm_listener() too.

v4:
- add a new patch, "add a build check for userspace_pm_dump_addr" as Matt suggested.
- patch 4, fix a warning here reported by CI:
WARNING: line length of 84 exceeds 80 columns
#27: FILE: net/mptcp/pm_userspace.c:468:

v3:
- drop "mptcp: update address type of get_local_id".

v2:
- a new patch "hold msk lock before removing id 0 address"

Drop the patch "mptcp: reuse sending nlmsg code in dump_addr", add a new helper mptcp_pm_genl_fill_addr() to save the duplicated code.

Define struct mptcp_pm_addr_id_bitmap in protocol.h, instead of defining mptcp_pm_addr_id_bitmap_t in include/net/mptcp.h, since get_addr() and dump_addr() interfaces of BPF userspace pm is dropped as Matt suggested.

Geliang Tang (5):
mptcp: add a build check for userspace_pm_dump_addr
mptcp: add mptcp_pm_genl_fill_addr helper
mptcp: drop match in userspace_pm_append_new_local_addr
mptcp: drop inet6_sk after inet_sk
mptcp: use ipv6_addr_equal in addresses_equal

 net/mptcp/pm.c           | 21 +++++++++++++++++++++
 net/mptcp/pm_netlink.c   | 22 ++++------------------
 net/mptcp/pm_userspace.c | 29 +++++++----------------------
 net/mptcp/protocol.h     |  3 +++
 4 files changed, 35 insertions(+), 40 deletions(-)
Signature · 1 line
2.43.0