mlxsw: Move Tx header handling to PCI driver
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mlxsw: Add mlxsw_txhdr_info structuredrivers/ drivers/ drivers/ +2 more | +23 | 0 replies | Applied |
| 2/5 | mlxsw: Initialize txhdr_info according to PTP operationsdrivers/ drivers/ drivers/ +1 more | +38 | 0 replies | Applied |
| 3/5 | mlxsw: Define Tx header fields in txheader.hdrivers/ drivers/ | +63 | 0 replies | Applied |
| 4/5 | mlxsw: Move Tx header handling to PCI driverdrivers/ drivers/ drivers/ +4 more | +65 | 1 reply | Applied |
| 5/5 | mlxsw: Do not store Tx header length as driver parameterdrivers/ drivers/ drivers/ | +2 | 0 replies | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ido Schimmel | Przemek Kitszel |
|---|---|---|
| Series | R-b | |
| 1/5 | R-b | |
| 2/5 | R-b | |
| 3/5 | R-b | |
| 4/5 | R-b | |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/5] mlxsw: Move Tx header handling to PCI driver
Amit Cohen writes:
Tx header should be added to all packets transmitted from the CPU to Spectrum ASICs. Historically, handling this header was added as a driver function, as Tx header is different between Spectrum and Switch-X.
From May 2021, there is no support for SwitchX-2 ASIC, and all the relevant code was removed.
For now, there is no justification to handle Tx header as part of spectrum.c, we can handle this as part of PCI, in skb_transmit().
This change will also be useful when XDP support will be added to mlxsw, as for XDP_TX and XDP_REDIRECT actions, Tx header should be added before transmitting the packet.
Patch set overview:
Patches #1-#2 add structure to store Tx header info and initialize it Patch #3 moves definitions of Tx header fields to txheader.h Patch #4 moves Tx header handling to PCI driver
Patch #5 removes unnecessary attribute
Amit Cohen (5):
mlxsw: Add mlxsw_txhdr_info structure
mlxsw: Initialize txhdr_info according to PTP operations
mlxsw: Define Tx header fields in txheader.h
mlxsw: Move Tx header handling to PCI driver
mlxsw: Do not store Tx header length as driver parameter
drivers/net/ethernet/mellanox/mlxsw/core.c | 21 +- drivers/net/ethernet/mellanox/mlxsw/core.h | 13 +- drivers/net/ethernet/mellanox/mlxsw/i2c.c | 2 +- drivers/net/ethernet/mellanox/mlxsw/pci.c | 44 +++- .../net/ethernet/mellanox/mlxsw/spectrum.c | 209 ++++-------------- .../net/ethernet/mellanox/mlxsw/spectrum.h | 11 +- .../ethernet/mellanox/mlxsw/spectrum_ptp.c | 44 +--- .../ethernet/mellanox/mlxsw/spectrum_ptp.h | 28 --- .../net/ethernet/mellanox/mlxsw/txheader.h | 63 ++++++ 9 files changed, 176 insertions(+), 259 deletions(-)
Signature · 1 line
2.47.0