Skip to content

Change ghes to use HEST-based offsets and add support for error inject

Mauro Carvalho Chehab kvm lkml qemu-arm qemu-devel 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest17 patches 2 repliesIn review
  2. v1117 patches 8 repliesSuperseded
  3. v1020 patches 9 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v920 patches7 repliesSuperseded
v820 patches10 repliesSuperseded
v719 patches0 repliesSuperseded
v619 patches16 repliesSuperseded
v521 patches16 repliesSuperseded
v414 patches19 repliesSuperseded
v314 patches28 repliesSuperseded
v213 patches18 repliesSuperseded
v111 patches30 repliesSuperseded

Changes in v12 from the cover letter

- some descriptions changed verbal tense to imperative;
- since updated at acpi-hest.json;
- added a g_free at qmp_inject_ghes_v2_error() and fixed coding style;
- fixed NOTIFIER_LIST_INITIALIZER() parameter;
- changed a patch description with a diff on it to avoid issues with git am.

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static"hw/acpi/ghes.c include/hw/acpi/ghes.h+6 -20 replies
2/17acpi/ghes: Cleanup the code which gets ghes ged statehw/acpi/ghes-stub.c hw/acpi/ghes.c include/hw/acpi/ghes.h +1 more+27 -390 replies
3/17acpi/ghes: prepare to change the way HEST offsets are calculatedhw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+45 -190 replies
4/17acpi/ghes: add a firmware file with HEST addresshw/acpi/ghes.c include/hw/acpi/ghes.h+25 -30 replies
5/17acpi/ghes: Use HEST table offsets when preparing GHES recordshw/acpi/ghes.c include/hw/acpi/ghes.h+101 -10 replies
6/17acpi/ghes: don't hard-code the number of sources for HEST tablehw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h +1 more+41 -250 replies
7/17acpi/ghes: add a notifier to notify when error data is readyhw/acpi/ghes.c include/hw/acpi/ghes.h+7 -10 replies
8/17acpi/generic_event_device: Update GHES migration to cover hest addrhw/acpi/generic_event_device.c+29 -00 replies
9/17acpi/generic_event_device: add logic to detect if HEST addr is availablehw/acpi/generic_event_device.c hw/arm/virt-acpi-build.c hw/core/machine.c+22 -30 replies
10/17acpi/generic_event_device: add an APEI error devicehw/acpi/aml-build.c hw/acpi/generic_event_device.c include/hw/acpi/acpi_dev_interface.h +2 more+27 -00 replies
11/17tests/acpi: virt: allow acpi table changes at DSDT and HEST tablestests/qtest/bios-tables-test-allowed-diff.h+9 -00 replies
12/17arm/virt: Wire up a GED error device for ACPI / GHEShw/arm/virt-acpi-build.c hw/arm/virt.c include/hw/arm/virt.h+13 -10 replies
13/17qapi/acpi-hest: add an interface to do generic CPER error injectionMAINTAINERS hw/acpi/Kconfig hw/acpi/ghes.c +10 more+123 -10 replies
14/17acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.xhw/acpi/generic_event_device.c+1 -10 replies
15/17tests/acpi: virt: update HEST and DSDT tablestests/data/acpi/aarch64/virt/DSDT tests/data/acpi/aarch64/virt/DSDT.acpihmatvirt tests/data/acpi/aarch64/virt/DSDT.acpipcihp +7 more+0 -90 replies
16/17docs: hest: add new "etc/acpi_table_hest_addr" and update workflowdocs/specs/acpi_hest_ghes.rst+17 -110 replies
17/17scripts/ghes_inject: add a script to generate GHES error injectMAINTAINERS scripts/arm_processor_error.py scripts/ghes_inject.py +1 more+1233 -01 reply

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchJonathan CameronIgor MammedovMauro Carvalho ChehabShiju JoseMarkus Armbruster
1/17R-b
2/17R-b R-b
3/17R-b R-b
4/17R-b R-b
5/17R-b R-b
6/17R-b R-b
7/17R-b A-b
8/17R-b R-b
9/17R-b R-b
10/17Co-authored-by R-b Co-authored-by
11/17R-b A-b
12/17Co-authored-by R-b A-b Co-authored-by
13/17Co-authored-by A-b Co-authored-by Co-authored-by A-b
14/17R-b R-b
15/17R-b A-b
16/17R-b R-b
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v12 thread

Cover letter [PATCH v12 00/17] Change ghes to use HEST-based offsets and add support for error inject

Hi Michael,

This is v11 of the patch series, rebased to apply after release 10.1. Just like v1, the difference against v10 is a minor conflict resolution.

Please apply as soon as possible to avoid new conflicts.

Thanks!

-

As ghes_record_cper_errors() was written since the beginning to be public and used by ghes-cper.c. It ended being meged earlier because the error-injection series become too big, so it was decided last year to split in two to make easier for reviewers and maintainers to discuss.

This series change the way HEST table offsets are calculated, making them identical to what an OSPM would do and allowing multiple HEST entries without causing migration issues. It open space to add HEST support for non-arm architectures, as now the number and type of HEST notification entries are not hardcoded at ghes.c. Instead, they're passed as a parameter from the arch-dependent init code.

With such issue addressed, it adds a new notification type and add support to inject errors via a Python script. The script itself is at the final patch.

---
v12:
- some descriptions changed verbal tense to imperative;
- since updated at acpi-hest.json;
- added a g_free at qmp_inject_ghes_v2_error() and fixed coding style;
- fixed NOTIFIER_LIST_INITIALIZER() parameter;
- changed a patch description with a diff on it to avoid issues with git am.

v11:
- rebased on the top of current upstream:
baa79455fa92 ("Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging")
- backward-compatibility logic moved to version 10.1;
- BIOS test tables re-generated, as DSDT tables changed on 10.0;
- added a missing SPDX tag on a new file.

v10:
- rebased on the top of current upstream:
d9ce74873a6a ("Merge tag 'pull-vfio-20250611' of https://github.com/legoater/qemu into staging")
- solved a minor conflict

v9:
- backward compatibility logic moved to version 10.0;
- fixed a compilation issue with target/arm/kvm.c (probably caused by some rebase - funny enough, incremental compilation was fine here);
- added two missing SPDX comments.

v8:
- added a patch to revert recently-added changeset causing a conflict with these. All remaining patches are identical.

v7:
- minor editorial change at the patch updating HEST doc spec with the new workflow

v6:
- some minor nits addressed:
- use GPA instead of offset;
- merged two patches;
- fixed a couple of long line coding style issues;
- the HEST/DSDT diff inside a patch was changed to avoid troubles applying it.

v5:
- make checkpatch happier;
- HEST table is now tested;
- some changes at HEST spec documentation to align with code changes;
- extra care was taken with regards to git bisectability.

v4:
- added an extra comment for AcpiGhesState structure;
- patches reordered;
- no functional changes, just code shift between the patches in this series.

v3:
- addressed more nits;
- hest_add_le now points to the beginning of HEST table;
- removed HEST from tests/data/acpi;
- added an extra patch to not use fw_cfg with virt-10.0 for hw_error_le

v2:
- address some nits;
- improved ags cleanup patch and removed ags.present field;
- added some missing le*_to_cpu() calls;
- update date at copyright for new files to 2024-2025;
- qmp command changed to: inject-ghes-v2-error ans since updated to 10.0;
- added HEST and DSDT tables after the changes to make check target happy. (two patches: first one whitelisting such tables; second one removing from whitelist and updating/adding such tables to tests/data/acpi)

Mauro Carvalho Chehab (17):
Revert "hw/acpi/ghes: Make ghes_record_cper_errors() static" acpi/ghes: Cleanup the code which gets ghes ged state acpi/ghes: prepare to change the way HEST offsets are calculated acpi/ghes: add a firmware file with HEST address acpi/ghes: Use HEST table offsets when preparing GHES records acpi/ghes: don't hard-code the number of sources for HEST table acpi/ghes: add a notifier to notify when error data is ready acpi/generic_event_device: Update GHES migration to cover hest addr acpi/generic_event_device: add logic to detect if HEST addr is
available
acpi/generic_event_device: add an APEI error device tests/acpi: virt: allow acpi table changes at DSDT and HEST tables arm/virt: Wire up a GED error device for ACPI / GHES qapi/acpi-hest: add an interface to do generic CPER error injection acpi/generic_event_device.c: enable use_hest_addr for QEMU 10.x tests/acpi: virt: update HEST and DSDT tables
docs: hest: add new "etc/acpi_table_hest_addr" and update workflow scripts/ghes_inject: add a script to generate GHES error inject

 MAINTAINERS                                   |  10 +
 docs/specs/acpi_hest_ghes.rst                 |  28 +-
 hw/acpi/Kconfig                               |   5 +
 hw/acpi/aml-build.c                           |  10 +
 hw/acpi/generic_event_device.c                |  44 ++
 hw/acpi/ghes-stub.c                           |   7 +-
 hw/acpi/ghes.c                                | 233 ++++--
 hw/acpi/ghes_cper.c                           |  40 +
 hw/acpi/ghes_cper_stub.c                      |  20 +
 hw/acpi/meson.build                           |   2 +
 hw/arm/virt-acpi-build.c                      |  35 +-
 hw/arm/virt.c                                 |  19 +-
 hw/core/machine.c                             |   5 +-
 include/hw/acpi/acpi_dev_interface.h          |   1 +
 include/hw/acpi/aml-build.h                   |   2 +
 include/hw/acpi/generic_event_device.h        |   1 +
 include/hw/acpi/ghes.h                        |  51 +-
 include/hw/arm/virt.h                         |   2 +
 qapi/acpi-hest.json                           |  36 +
 qapi/meson.build                              |   1 +
 qapi/qapi-schema.json                         |   1 +
 scripts/arm_processor_error.py                | 476 ++++++++++++
 scripts/ghes_inject.py                        |  51 ++
 scripts/qmp_helper.py                         | 703 ++++++++++++++++++
 target/arm/kvm.c                              |   7 +-
 tests/data/acpi/aarch64/virt/DSDT             | Bin 5293 -> 5337 bytes
 .../data/acpi/aarch64/virt/DSDT.acpihmatvirt  | Bin 5379 -> 5423 bytes
 tests/data/acpi/aarch64/virt/DSDT.acpipcihp   | Bin 6202 -> 6246 bytes
 .../acpi/aarch64/virt/DSDT.hpoffacpiindex     | Bin 5347 -> 5391 bytes
 tests/data/acpi/aarch64/virt/DSDT.memhp       | Bin 6654 -> 6698 bytes
 tests/data/acpi/aarch64/virt/DSDT.pxb         | Bin 7768 -> 7812 bytes
 tests/data/acpi/aarch64/virt/DSDT.topology    | Bin 5495 -> 5539 bytes
 tests/data/acpi/aarch64/virt/DSDT.viot        | Bin 5310 -> 5354 bytes
 tests/data/acpi/aarch64/virt/HEST             | Bin 132 -> 224 bytes
 34 files changed, 1700 insertions(+), 90 deletions(-)
 create mode 100644 hw/acpi/ghes_cper.c
 create mode 100644 hw/acpi/ghes_cper_stub.c
 create mode 100644 qapi/acpi-hest.json
 create mode 100644 scripts/arm_processor_error.py
 create mode 100755 scripts/ghes_inject.py
 create mode 100755 scripts/qmp_helper.py
Signature · 1 line
2.51.0