Skip to content

drm/i915/dp: dsc fix, refactoring and cleanups

Jani Nikula intel-gfx intel-xe stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 18 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14drm/i915/dp: Iterate DSC BPP from high to low on all platformsdrivers/gpu/drm/i915/display/intel_dp.c+3 -43 replies
2/14drm/i915/dp: Add intel_dp_dsc_bpp_step_x16() helper to get DSC BPP precisiondrivers/gpu/drm/i915/display/intel_dp.c+16 -53 replies
3/14drm/i915/dp: Rename some variables in xelpd_dsc_compute_link_config()drivers/gpu/drm/i915/display/intel_dp.c+8 -111 reply
4/14drm/i915/dp: Pass .4 BPP values to {icl, xelpd}_dsc_compute_link_config()drivers/gpu/drm/i915/display/intel_dp.c+16 -121 reply
5/14drm/i915/dp: Move max DSC BPP reduction one level higherdrivers/gpu/drm/i915/display/intel_dp.c+14 -181 reply
6/14drm/i915/dp: Change icl_dsc_compute_link_config() DSC BPP iterationdrivers/gpu/drm/i915/display/intel_dp.c+26 -71 reply
7/14drm/i915/dp: Move force_dsc_fractional_bpp_en check to intel_dp_dsc_valid_bpp()drivers/gpu/drm/i915/display/intel_dp.c+7 -31 reply
8/14drm/i915/dp: Unify DSC link config functionsdrivers/gpu/drm/i915/display/intel_dp.c+5 -441 reply
9/14drm/i915/dp: Inline do_dsc_compute_compressed_bpp()drivers/gpu/drm/i915/display/intel_dp.c+23 -371 reply
10/14drm/i915/dp: Simplify input BPP checks in intel_dp_dsc_compute_pipe_bpp()drivers/gpu/drm/i915/display/intel_dp.c+2 -81 reply
11/14drm/i915/dp: Use int for compressed BPP in dsc_compute_link_config()drivers/gpu/drm/i915/display/intel_dp.c+4 -42 replies
12/14drm/i915/dp: Drop compute_pipe_bpp parameter from intel_dp_dsc_compute_config()drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp.h drivers/gpu/drm/i915/display/intel_dp_mst.c+8 -111 reply
13/14drm/i915/dp: Pass connector state all the way to dsc_compute_link_config()drivers/gpu/drm/i915/display/intel_dp.c+6 -31 reply
14/14drm/i915/mst: Convert intel_dp_mtp_tu_compute_config() to .4 formatdrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_mst.c drivers/gpu/drm/i915/display/intel_dp_mst.h+33 -251 reply

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchImre DeakAnkit Nautiyal
1/14R-b R-b
2/14R-b R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b
8/14R-b
9/14R-b
10/14R-b
11/14R-b
12/14R-b
13/14R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/14] drm/i915/dp: dsc fix, refactoring and cleanups

This started off as preparation for UHBR SST DSC enabling, but escalated quickly. The SST DSC code is unnecessarily complicated with the platform differences and ints and fixed points being mixed. Clean it up quite a bit, reducing the number of lines in the process.

BR,
Jani.

Jani Nikula (14):
drm/i915/dp: Iterate DSC BPP from high to low on all platforms drm/i915/dp: Add intel_dp_dsc_bpp_step_x16() helper to get DSC BPP
precision
drm/i915/dp: Rename some variables in xelpd_dsc_compute_link_config() drm/i915/dp: Pass .4 BPP values to
{icl,xelpd}_dsc_compute_link_config()
drm/i915/dp: Move max DSC BPP reduction one level higher drm/i915/dp: Change icl_dsc_compute_link_config() DSC BPP iteration drm/i915/dp: Move force_dsc_fractional_bpp_en check to
intel_dp_dsc_valid_bpp()
drm/i915/dp: Unify DSC link config functions
drm/i915/dp: Inline do_dsc_compute_compressed_bpp() drm/i915/dp: Simplify input BPP checks in
intel_dp_dsc_compute_pipe_bpp()
drm/i915/dp: Use int for compressed BPP in dsc_compute_link_config() drm/i915/dp: Drop compute_pipe_bpp parameter from
intel_dp_dsc_compute_config()
drm/i915/dp: Pass connector state all the way to
dsc_compute_link_config()
drm/i915/mst: Convert intel_dp_mtp_tu_compute_config() to .4 format

 drivers/gpu/drm/i915/display/intel_dp.c     | 194 +++++++++-----------
 drivers/gpu/drm/i915/display/intel_dp.h     |   3 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c |  54 +++---
 drivers/gpu/drm/i915/display/intel_dp_mst.h |   2 +-
 4 files changed, 116 insertions(+), 137 deletions(-)
Signature · 1 line
2.39.5