Skip to content

GNUmakefile, share/mk/: Use ?=, and require users to specify -R

Alejandro Colomar linux-man 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3GNUmakefile: Require the user to specify '-R' if their make(1) is too oldGNUmakefile+8 -10 replies
2/3share/mk/: Use ?= assignments for user-facing variablesGNUmakefile share/mk/configure/build-depends/binutils/ld.mk share/mk/configure/build-depends/bsdextrautils/col.mk +62 more+147 -1470 replies
3/3GNUmakefile: help: Show only variables assigned with '?='GNUmakefile+2 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] GNUmakefile, share/mk/: Use ?=, and require users to specify -R

Hi Sam, Paul, Guenther,

I've rumiated this idea for some months already: I can use ?=, as long as I force users to add a dummy -R to the command line. The dummy -R will only be required if they GNU make(1) is too old (but everyone's make(1) is too old, because the requirement will be 4.5, so...). That's a minor inconvenience, but anyway, I should do it even when 4.5 is out and I move to ?=, because otherwise people running on old make(1) would have a broken build system, so I really need to force people to specify -R.

What do you think about it?

Here are the patches for the Linux man-pages build system. Please have a look at them. :)

Have a lovely day!
Alex

P.S.: Guenther, I just CCd you in case you were curious about this. ;)

Alejandro Colomar (3):
GNUmakefile: Require the user to specify '-R' if their make(1) is too
old
share/mk/: Use ?= assignments for user-facing variables
GNUmakefile: help: Show only variables assigned with '?='

 GNUmakefile                                   | 16 +++++++++-----
 .../mk/configure/build-depends/binutils/ld.mk |  8 +++----
 .../build-depends/bsdextrautils/col.mk        |  6 ++---
 .../mk/configure/build-depends/bzip2/bzip2.mk |  6 ++---
 .../build-depends/checkpatch/checkpatch.mk    |  6 ++---
 .../build-depends/clang-tidy/clang-tidy.mk    |  6 ++---
 .../mk/configure/build-depends/clang/clang.mk |  4 ++--
 .../configure/build-depends/coreutils/cat.mk  |  2 +-
 .../configure/build-depends/coreutils/cp.mk   |  2 +-
 .../configure/build-depends/coreutils/cut.mk  |  2 +-
 .../configure/build-depends/coreutils/echo.mk |  2 +-
 .../configure/build-depends/coreutils/expr.mk |  2 +-
 .../configure/build-depends/coreutils/head.mk |  2 +-
 .../build-depends/coreutils/install.mk        |  8 +++----
 .../configure/build-depends/coreutils/ln.mk   |  2 +-
 .../build-depends/coreutils/mkdir.mk          |  2 +-
 .../build-depends/coreutils/realpath.mk       |  2 +-
 .../configure/build-depends/coreutils/rm.mk   |  2 +-
 .../configure/build-depends/coreutils/sort.mk |  2 +-
 .../configure/build-depends/coreutils/stat.mk |  2 +-
 .../configure/build-depends/coreutils/tac.mk  |  2 +-
 .../configure/build-depends/coreutils/tail.mk |  2 +-
 .../configure/build-depends/coreutils/test.mk |  2 +-
 .../build-depends/coreutils/touch.mk          |  2 +-
 .../configure/build-depends/coreutils/true.mk |  2 +-
 share/mk/configure/build-depends/cpp/cpp.mk   |  6 ++---
 .../build-depends/cppcheck/cppcheck.mk        |  6 ++---
 .../build-depends/cpplint/cpplint.mk          |  6 ++---
 .../build-depends/diffoscope/diffoscope.mk    |  2 +-
 .../configure/build-depends/findutils/find.mk |  2 +-
 .../build-depends/findutils/xargs.mk          |  2 +-
 .../build-depends/fontforge/fontforge.mk      |  6 ++---
 share/mk/configure/build-depends/gcc/cc.mk    |  6 ++---
 share/mk/configure/build-depends/git/git.mk   |  2 +-
 share/mk/configure/build-depends/grep/grep.mk |  2 +-
 .../configure/build-depends/groff-base/eqn.mk |  6 ++---
 .../build-depends/groff-base/grops.mk         |  6 ++---
 .../build-depends/groff-base/grotty.mk        |  6 ++---
 .../build-depends/groff-base/nroff.mk         | 10 ++++-----
 .../configure/build-depends/groff-base/pic.mk |  6 ++---
 .../build-depends/groff-base/preconv.mk       |  6 ++---
 .../configure/build-depends/groff-base/tbl.mk |  2 +-
 .../build-depends/groff-base/troff.mk         |  6 ++---
 .../configure/build-depends/groff/afmtodit.mk | 10 ++++-----
 .../configure/build-depends/groff/gropdf.mk   |  6 ++---
 .../configure/build-depends/groff/pfbtops.mk  |  6 ++---
 .../build-depends/groff/post-grohtml.mk       |  6 ++---
 share/mk/configure/build-depends/gzip/gzip.mk |  6 ++---
 share/mk/configure/build-depends/iwyu/iwyu.mk |  6 ++---
 .../build-depends/libc-bin/locale.mk          |  2 +-
 share/mk/configure/build-depends/lzip/lzip.mk |  6 ++---
 .../configure/build-depends/mandoc/mandoc.mk  |  6 ++---
 .../build-depends/moreutils/sponge.mk         |  2 +-
 .../build-depends/pkgconf/pkgconf.mk          |  8 +++----
 share/mk/configure/build-depends/sed/sed.mk   |  2 +-
 .../build-depends/shellcheck/shellcheck.mk    |  6 ++---
 share/mk/configure/build-depends/tar/tar.mk   |  6 ++---
 .../Tinos-Regular.ttf.mk                      |  2 +-
 .../texlive-fonts-extra/Tinos.pfb.mk          |  2 +-
 .../mk/configure/build-depends/xz-utils/xz.mk |  6 ++---
 .../mk/configure/directory_variables/build.mk |  2 +-
 .../configure/directory_variables/install.mk  | 22 +++++++++----------
 share/mk/configure/man/link_pages.mk          |  2 +-
 share/mk/configure/version.mk                 | 10 ++++-----
 share/mk/configure/xfail.mk                   |  2 +-
 65 files changed, 157 insertions(+), 151 deletions(-)

base-commit: 2904e040ded291a898aa5e74b361d12ec90d5a2d

Signature · 1 line
2.47.2