Skip to content

KVM: x86: Address performance degradation due to APICv inhibits

Naveen N Rao (AMD) kvm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3KVM: x86: hyper-v: Convert synic_auto_eoi_used to an atomicarch/x86/include/asm/kvm_host.h arch/x86/kvm/hyperv.c+7 -174 replies
2/3KVM: x86: Remove use of apicv_update_lock when toggling guest debug statearch/x86/kvm/x86.c+2 -77 replies
3/3KVM: x86: Decouple APICv activation state from apicv_inhibit_reasonsarch/x86/include/asm/kvm_host.h arch/x86/kvm/x86.c+63 -6015 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMaxim Levitsky
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] KVM: x86: Address performance degradation due to APICv inhibits

When AVIC is enabled (kvm_amd avic=1), guests with kernel-irqchip=on and PIT in reinject mode (default configuration) show degraded performance. This is because even though APICv is inhibited, we see other inhibits being set/cleared causing contention on apicv_update_lock. Rework inhibit code so that apicv_update_lock is not required unless APICv state is changing. More details in patch 3.

In a test setup with two guests (-smp 16, -netdev tap,vhost=on, -device virtio-net-pci,mq=on), multiple instances of netperf TCP_RR sending traffic to the other guest, sar shows:

Without this patch series, kvm_amd avic=0 (default):

Average:        IFACE   rxpck/s   txpck/s    rxkB/s    txkB/s   rxcmp/s   txcmp/s  rxmcst/s   %ifutil
Average:           lo      0.00      0.00      0.00      0.00      0.00      0.00      0.00      0.00
Average:         ens2 1323407.59 1323406.87 250722.47 126654.46      0.00      0.00      0.00      0.00

Without this patch series, kvm_amd avic=1:

Average:        IFACE   rxpck/s   txpck/s    rxkB/s    txkB/s   rxcmp/s   txcmp/s  rxmcst/s   %ifutil
Average:           lo      0.00      0.00      0.00      0.00      0.00      0.00      0.00      0.00
Average:         ens2 1057711.25 1057697.51 200385.83 101225.23      0.00      0.00      0.00      0.00

We see ~20% degradation in packet rate.

With this patch series, kvm_amd avic=1:

Average:        IFACE   rxpck/s   txpck/s    rxkB/s    txkB/s   rxcmp/s   txcmp/s  rxmcst/s   %ifutil
Average:           lo      0.00      0.00      0.00      0.00      0.00      0.00      0.00      0.00
Average:         ens2 1315433.91 1315434.46 249211.99 125891.47      0.00      0.00      0.00      0.00

- Naveen

Naveen N Rao (AMD) (3):
KVM: x86: hyper-v: Convert synic_auto_eoi_used to an atomic
KVM: x86: Remove use of apicv_update_lock when toggling guest debug
state
KVM: x86: Decouple APICv activation state from apicv_inhibit_reasons

 arch/x86/include/asm/kvm_host.h |  14 ++--
 arch/x86/kvm/hyperv.c           |  17 ++---
 arch/x86/kvm/x86.c              | 125 ++++++++++++++++----------------
 3 files changed, 72 insertions(+), 84 deletions(-)

base-commit: eb723766b1030a23c38adf2348b7c3d1409d11f0

Signature · 1 line
2.48.1