Skip to content

Add QMI Device Service Request Rate-limit Option

Grant Erickson ofono 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 0 repliesNew
  2. v57 patches 1 replySuperseded
  3. v47 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches3 repliesSuperseded
v27 patches4 repliesSuperseded
v110 patches8 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7qmi: Added enumeration for device quirk flags.drivers/qmimodem/qmi.h+18 -00 replies
2/7qmi: Added structure for device options.drivers/qmimodem/qmi.h+19 -00 replies
3/7qmi: Added device options parameter to 'qmi_qmux_device_new'.drivers/qmimodem/qmi.c drivers/qmimodem/qmi.h+4 -20 replies
4/7qmi: Implement QMI service request rate limiting in 'can_write_data'.drivers/qmimodem/qmi.c+38 -00 replies
5/7qmi: Handle request rate limit option in 'qmi_qmux_device_new'.drivers/qmimodem/qmi.c+10 -00 replies
6/7udevng: Set the QMI minimum service request period for Quectel BG96 modems.plugins/udevng.c+14 -00 replies
7/7gobi: Pass QMI qmux device options to 'qmi_qmux_device_new'.plugins/gobi.c+21 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/7] Add QMI Device Service Request Rate-limit Option

Certain modems, among them the Quectel Wireless Solutions Co., Ltd. (2c7c) BG96 CAT-M1/NB-IoT modem (0296), have a firmware issue where they can lock up and hang (not responding to subsequent commands) due to high QMI service request arrival rates.

QMI service request rate limiting is achieved by:

1. Adding a new, optional options structure to qmi_qmux_device_new that has its rate-limit "quirk" and minimum request period fields set when the modem "RequestThrottleTimeUs" integer property is set.

2. Adding logic to the QMI driver that, when a minimum request period is set, limits the QMI service request rate accordingly.

(1) and (2) are used by the udevng and gobi plugins such that when the modem vendor and model match 2c7c/0296, then the option to rate limit QMI service requests is set to no more than one every 2,000 us.

Grant Erickson (7):
qmi: Added enumeration for device quirk flags.
qmi: Added structure for device options.
qmi: Added device options parameter to 'qmi_qmux_device_new'.
qmi: Implement QMI service request rate limiting in 'can_write_data'.
qmi: Handle request rate limit option in 'qmi_qmux_device_new'.
udevng: Set the QMI minimum service request period for Quectel BG96
modems.
gobi: Pass QMI qmux device options to 'qmi_qmux_device_new'.

 drivers/qmimodem/qmi.c | 51 +++++++++++++++++++++++++++++++++++++++++-
 drivers/qmimodem/qmi.h | 40 ++++++++++++++++++++++++++++++++-
 plugins/gobi.c         | 22 +++++++++++++++++-
 plugins/udevng.c       | 14 ++++++++++++
 4 files changed, 124 insertions(+), 3 deletions(-)
Signature · 1 line
2.45.0