Skip to content

drm/i915: display reset cleanups

Jani Nikula intel-gfx intel-xe 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 6 repliesIn review
  2. v28 patches 9 repliesSuperseded
  3. v114 patches 16 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/i915/display: convert display reset to struct intel_display *drivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_display_reset.h drivers/gpu/drm/i915/gt/intel_reset.c+35 -290 replies
2/8drm/i915: move pending_fb_pin to struct intel_displaydrivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_dpt.c +3 more+14 -120 replies
3/8drm/i915/reset: add intel_gt_gpu_reset_clobbers_display() helperdrivers/gpu/drm/i915/gt/intel_engine_cs.c drivers/gpu/drm/i915/gt/intel_gt_pm.c drivers/gpu/drm/i915/gt/intel_reset.c +2 more+16 -70 replies
4/8drm/i915/reset: add intel_display_reset_test()drivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_display_reset.h+9 -10 replies
5/8drm/i915/reset: remove I915_RESET_MODESET flagdrivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_display_reset.h drivers/gpu/drm/i915/gt/intel_reset.c +1 more+15 -221 reply
6/8drm/i915/reset: decide whether display reset is needed on gt sidedrivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/gt/intel_reset.c+9 -61 reply
7/8drm/i915/reset: pass test only parameter to intel_display_reset_finish()drivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_display_reset.h drivers/gpu/drm/i915/gt/intel_reset.c+4 -121 reply
8/8drm/i915/reset: add modeset_stuck callback to intel_display_reset_prepare()drivers/gpu/drm/i915/display/intel_display_reset.c drivers/gpu/drm/i915/display/intel_display_reset.h drivers/gpu/drm/i915/gt/intel_reset.c+15 -51 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMatt Roper
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/8] drm/i915: display reset cleanups

v3 of [1], removing I915_RESET_MODESET flag altogether for even further simplification.

BR,
Jani.

[1] https://lore.kernel.org/r/[email protected]

Jani Nikula (8):
drm/i915/display: convert display reset to struct intel_display * drm/i915: move pending_fb_pin to struct intel_display drm/i915/reset: add intel_gt_gpu_reset_clobbers_display() helper drm/i915/reset: add intel_display_reset_test() drm/i915/reset: remove I915_RESET_MODESET flag drm/i915/reset: decide whether display reset is needed on gt side drm/i915/reset: pass test only parameter to
intel_display_reset_finish()
drm/i915/reset: add modeset_stuck callback to
intel_display_reset_prepare()

 .../gpu/drm/i915/display/intel_display_core.h |  2 +
 .../drm/i915/display/intel_display_reset.c    | 73 ++++++++-----------
 .../drm/i915/display/intel_display_reset.h    | 12 ++-
 drivers/gpu/drm/i915/display/intel_dpt.c      |  5 +-
 drivers/gpu/drm/i915/display/intel_fb_pin.c   | 10 ++-
 drivers/gpu/drm/i915/display/intel_overlay.c  |  5 +-
 drivers/gpu/drm/i915/gt/intel_engine_cs.c     |  2 +-
 drivers/gpu/drm/i915/gt/intel_gt_pm.c         |  2 +-
 drivers/gpu/drm/i915/gt/intel_reset.c         | 41 +++++++++--
 drivers/gpu/drm/i915/gt/intel_reset.h         |  2 +
 drivers/gpu/drm/i915/gt/intel_reset_types.h   |  3 +-
 drivers/gpu/drm/i915/i915_driver.c            |  2 +-
 drivers/gpu/drm/i915/i915_gpu_error.h         |  2 -
 13 files changed, 92 insertions(+), 69 deletions(-)
Signature · 1 line
2.39.5