btrfs: prepare for larger folios support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 8 repliesIn review
- v15 patches 11 repliesSuperseded
Changes in v2 from the cover letter
- Split the subpage.[ch] modification into 3 patches
- Rebased the latest for-next branch
Now all dependency are in for-next.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | btrfs: subpage: make btrfs_is_subpage() check against a foliofs/ fs/ fs/ +1 more | +26 | 0 replies | |
| 2/6 | btrfs: add a @fsize parameter to btrfs_alloc_subpage()fs/ fs/ fs/ | +6 | 0 replies | |
| 3/6 | btrfs: replace PAGE_SIZE with folio_size for subpage.[ch]fs/ fs/ | +4 | 0 replies | |
| 4/6 | btrfs: prepare btrfs_launcher_folio() for larger folios supportfs/ | +1 | 0 replies | |
| 5/6 | btrfs: prepare extent_io.c for future larger folio supportfs/ | +19 | 2 replies | |
| 6/6 | btrfs: prepare btrfs_page_mkwrite() for larger foliosfs/ | +10 | 0 replies |
Reviews trailers per patch
2 of 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Johannes Thumshirn | Boris Burkov |
|---|---|---|
| Series | R-b | R-b |
| 1/6 | ||
| 2/6 | ||
| 3/6 | ||
| 4/6 | R-b | |
| 5/6 | ||
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/6] btrfs: prepare for larger folios support
[CHANGELOG]
v2:
- Split the subpage.[ch] modification into 3 patches
- Rebased the latest for-next branch
Now all dependency are in for-next.
This means:
- Our subpage routine should check against the folio size other than PAGE_SIZE
- Make functions handling filemap folios to use folio_size() other than PAGE_SIZE
The most common paths are:
* Buffered reads/writes
* Uncompressed folio writeback
Already handled pretty well
* Compressed read
* Compressed write
To take full advantage of larger folios, we should use folio_iter other than bvec_iter.
This will be a dedicated patchset, and the existing bvec_iter can still handle larger folios.
Internal usages can still use page sized folios, or even pages, including:
* Encoded reads/writes
* Compressed folios
* RAID56 internal pages
* Scrub internal pages
This patchset will handle the above mentioned points by:
- Prepare the subpage routine to handle larger folios
This will introduce a small overhead, as all checks are against folio sizes, even on x86_64 we can no longer skip subpage completely.
This is done in the first patch.
- Convert straightforward PAGE_SIZE users to use folio_size() This is done in the remaining patches.
Currently this patchset is not a exhaustive conversion, I'm pretty sure there are other complex situations which can cause problems. Those problems can only be exposed and fixed after switching on the experimental larger folios support later.
Qu Wenruo (6):
btrfs: subpage: make btrfs_is_subpage() check against a folio
btrfs: add a @fsize parameter to btrfs_alloc_subpage()
btrfs: replace PAGE_SIZE with folio_size for subpage.[ch]
btrfs: prepare btrfs_launcher_folio() for larger folios support
btrfs: prepare extent_io.c for future larger folio support
btrfs: prepare btrfs_page_mkwrite() for larger folios
fs/btrfs/extent_io.c | 49 ++++++++++++++++++++++++-------------------- fs/btrfs/file.c | 19 +++++++++-------- fs/btrfs/inode.c | 4 ++-- fs/btrfs/subpage.c | 38 +++++++++++++++++----------------- fs/btrfs/subpage.h | 16 +++++++-------- 5 files changed, 66 insertions(+), 60 deletions(-)
Signature · 1 line
2.48.1