Skip to content

RFC x86/apic: SVM AVIC tests and some cleanups

Naveen N Rao (AMD) kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86/apic: Move ioapic tests together and add them to apic test groupx86/unittests.cfg+7 -60 replies
2/4x86/apic: Disable PIT for x2apic test to allow SVM AVIC to be testedx86/unittests.cfg+2 -11 reply
3/4x86/apic: Disable PIT for ioapic test to allow SVM AVIC to be testedx86/unittests.cfg+1 -10 replies
4/4x86/apic: Add test for xapic-splitx86/unittests.cfg+8 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC kvm-unit-tests PATCH 0/4] x86/apic: SVM AVIC tests and some cleanups

The first patch is a small cleanup. The next two patches update tests to disable PIT so that SVM AVIC can be exercized. The last patch adds a test for x1apic-split.

The last patch causes aliased apic_id ipi test to fail with older qemu versions. Qemu v6.2 and before used to enable KVM_X2APIC_API_USE_32BIT_IDS KVM quirk in some scenarios, and this was changed in commit dc89f32d92bb ("target/i386: Fix sanity check on max APIC ID / X2APIC enablement") to be enabled only if there are > 255 vcpus. The KUT test does talk about this assumption in a comment:
/*
* By default, KVM doesn't follow the x86 APIC architecture for aliased
* APIC IDs if userspace has enabled KVM_X2APIC_API_USE_32BIT_IDS.
* If x2APIC is supported, assume the userspace VMM has enabled 32-bit
* IDs and thus activated KVM's quirk. Delete this code to run the
* aliasing test on x2APIC CPUs, e.g. to run it on bare metal. */

That looks to suggest that this is an expected failure, but it would be good to get confirmation on the same.

Thanks,
Naveen

Naveen N Rao (AMD) (4):
x86/apic: Move ioapic tests together and add them to apic test group x86/apic: Disable PIT for x2apic test to allow SVM AVIC to be tested x86/apic: Disable PIT for ioapic test to allow SVM AVIC to be tested x86/apic: Add test for xapic-split

 x86/unittests.cfg | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

base-commit: 699264f5ef8129c60e9db7c281e572016ad41a45

Signature · 1 line
2.48.1