Skip to content

gpio: Hide and obey valid_mask

Matti Vaittinen linux-arm-msm linux-gpio lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 6 repliesApplied
  2. v24 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- Rebased on top of the gpio/for-next

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4gpio: Respect valid_mask when requesting GPIOsdrivers/gpio/gpiolib.c+5 -50 replies
2/4gpio: Add a valid_mask getterdrivers/gpio/gpiolib.c include/linux/gpio/driver.h+17 -00 replies
3/4gpio: gpio-rcar: Drop direct use of valid_maskdrivers/gpio/gpio-rcar.c+5 -80 replies
4/4gpio: Hide valid_mask from direct assignmentsdrivers/gpio/gpiolib.c drivers/gpio/gpiolib.h include/linux/gpio/driver.h+11 -165 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] gpio: Hide and obey valid_mask

GPIO controllers may have some pins which can be excluded from the GPIO usage on certain hardware configurations. The valid_mask member of the struct gpio_chip has been used to denote usable pins if some pins should be excluded.

The GPIO request should fail for GPIOs which are masked. Under certain conditions this was only done when GPIO chip provided the 'request' callback. We fix this to be always done.

The valid_mask member of the gpio_chip should no longer be directly populated by the drivers but GPIO core does this (unconditionally, overwriting any mask set directly by the drivers). Drivers are intended to populate the valid_mask using the init_valid_mask -callback.

This series enforces using the init_valid_mask by hiding the valid_mask in structure which is internal to the GPIO core. A single in-tree driver was found to access the valid_mask directly. This series also removes those direct accesses as has been discussed [1]. Additionally, we introduce a getter-function which can be used to obtain the valid_mask.

[1]: https://lore.kernel.org/all/TY3PR01MB11346EC54C8672C4D28F931F686CC2@TY3PR01MB11346.jpnprd01.prod.outlook.com/

Revision history:
v2 => v3:
- Rebased on top of the gpio/for-next
v1 => v2:
- Hide the 'valid_mask' instead of documenting it to be internal
- Make the gpio_request() to obey the valid_mask whether the gpio_chip has the 'request' -callback populated or not.

---

Matti Vaittinen (4):
gpio: Respect valid_mask when requesting GPIOs
gpio: Add a valid_mask getter
gpio: gpio-rcar: Drop direct use of valid_mask
gpio: Hide valid_mask from direct assignments

 drivers/gpio/gpio-rcar.c    | 13 +++++-------
 drivers/gpio/gpiolib.c      | 40 ++++++++++++++++++++++++++-----------
 drivers/gpio/gpiolib.h      |  3 +++
 include/linux/gpio/driver.h |  9 +--------
 4 files changed, 37 insertions(+), 28 deletions(-)

base-commit: 44fe79020b91a1a8620e44d4f361b389e8fc552f

Signature · 1 line
2.48.1