Skip to content

bus: qcom-ssc-block-bus: Fix some error handling paths

Christophe JAILLET kernel-janitors linux-arm-msm lkml 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2bus: qcom-ssc-block-bus: Remove some duplicated iounmap() callsdrivers/bus/qcom-ssc-block-bus.c+0 -31 reply
2/2bus: qcom-ssc-block-bus: Fix the error handling path of qcom_ssc_block_bus_probe()drivers/bus/qcom-ssc-block-bus.c+19 -121 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDmitry Baryshkov
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] bus: qcom-ssc-block-bus: Fix some error handling paths

Patch 1 should be straight forward. It removes some ioumap() from resources allocated with devm_ioremap_resource().

Patch 2 is more speculative. It releases some resources in the error handling path of the probe, as done in the .remove() function.

Finally, the .remove() function also has some

	pm_runtime_disable(&pdev->dev);
	pm_clk_destroy(&pdev->dev);

calls.

Usually pm_runtime_disable() is paired with pm_runtime_enable() and I would expect some pm_clk_add(() calls related to pm_clk_destroy(). Neither exists.

So I wonder if these 2 calls are correct in the .remove() function. Thought?

Christophe JAILLET (2):
bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls
bus: qcom-ssc-block-bus: Fix the error handling path of
qcom_ssc_block_bus_probe()

 drivers/bus/qcom-ssc-block-bus.c | 34 ++++++++++++++++++--------------
 1 file changed, 19 insertions(+), 15 deletions(-)
Signature · 1 line
2.48.1