bus: qcom-ssc-block-bus: Fix some error handling paths
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | bus: qcom-ssc-block-bus: Remove some duplicated iounmap() callsdrivers/ | +0 | 1 reply | |
| 2/2 | bus: qcom-ssc-block-bus: Fix the error handling path of qcom_ssc_block_bus_probe()drivers/ | +19 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Dmitry Baryshkov |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] bus: qcom-ssc-block-bus: Fix some error handling paths
Patch 1 should be straight forward. It removes some ioumap() from resources allocated with devm_ioremap_resource().
Patch 2 is more speculative. It releases some resources in the error handling path of the probe, as done in the .remove() function.
Finally, the .remove() function also has some
pm_runtime_disable(&pdev->dev); pm_clk_destroy(&pdev->dev);
calls.
Usually pm_runtime_disable() is paired with pm_runtime_enable() and I would expect some pm_clk_add(() calls related to pm_clk_destroy(). Neither exists.
So I wonder if these 2 calls are correct in the .remove() function. Thought?
Christophe JAILLET (2):
bus: qcom-ssc-block-bus: Remove some duplicated iounmap() calls
bus: qcom-ssc-block-bus: Fix the error handling path of
qcom_ssc_block_bus_probe()
drivers/bus/qcom-ssc-block-bus.c | 34 ++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 15 deletions(-)
Signature · 1 line
2.48.1