Skip to content

RFC Attempt to add GHES for x86

Mauro Carvalho Chehab lkml qemu-arm qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3acpi/ghes: move use_hest_addr out of acpi_build_hest()hw/acpi/ghes.c hw/arm/virt-acpi-build.c include/hw/acpi/ghes.h+29 -241 reply
2/3hw/i186: add support for HEST table with SCIhw/i386/Kconfig hw/i386/acpi-build.c hw/i386/pc.c +1 more+81 -00 replies
3/3Add a GED device for RAS notificationhw/i386/acpi-build.c hw/i386/pc.c include/hw/i386/x86.h+47 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/3] Attempt to add GHES for x86

Hi Igor,

This patch series comes after:
https://lore.kernel.org/qemu-devel/[email protected]/

I'm basically trying to add support for error injection for x86, without success so far.

On x86, the notification mechanism is different: it is via QMP. Yet, from what I saw on Linux implementation, it works on a similar way to GED. So, I ended implementing a notification via GED.

HEST table build seems to be working OK on it, and the error injection notification for x86 is called. Yet, OSPM is not receiving any notifications.

Could you help me figuring out what are the missing bits?

PS.: there are some things at the code that require polishing, plus there are some extra printf() there to help debugging. Finally, we would need to add x86 CPU error event at the ghes script, but I'd like to have at least something that the OSPM receives before improving it further.

It can be tested with:

   $ ./scripts/ghes_inject.py arm

(Ok, this would be generating an ARM processor event , but I guess Linux would at least mark the event as read, even if it doesn't recognize it)

Mauro Carvalho Chehab (3):
acpi/ghes: move use_hest_addr out of acpi_build_hest() hw/i186: add support for HEST table with SCI Add a GED device for RAS notification

 hw/acpi/ghes.c           | 16 ++++-----
 hw/arm/virt-acpi-build.c | 12 ++++---
 hw/i386/Kconfig          |  1 +
 hw/i386/acpi-build.c     | 75 ++++++++++++++++++++++++++++++++++++++++
 hw/i386/pc.c             | 41 ++++++++++++++++++++++
 include/hw/acpi/ghes.h   | 25 +++++++-------
 include/hw/i386/pc.h     |  5 +++
 include/hw/i386/x86.h    |  2 ++
 8 files changed, 153 insertions(+), 24 deletions(-)
Signature · 1 line
2.48.1