Skip to content

btrfs: fix unexpected delayed iputs at umount time and cleanups

[email protected] linux-btrfs 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v14 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs: fix non-empty delayed iputs list on unmount due to endio workersfs/btrfs/disk-io.c+9 -03 replies
2/4btrfs: fix non-empty delayed iputs list on unmount due to compressed write workersfs/btrfs/disk-io.c+12 -00 replies
3/4btrfs: move __btrfs_bio_end_io() code into its single callerfs/btrfs/bio.c+9 -130 replies
4/4btrfs: move btrfs_cleanup_bio() code into its single callerfs/btrfs/bio.c+5 -90 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchQu Wenruo
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] btrfs: fix unexpected delayed iputs at umount time and cleanups

From: Filipe Manana <[email protected]>

Fix a couple races that can result in adding delayed iputs during umount after we no longer expect to find any, triggering an assertion failure. Plus a couple cleanups. Details in the change logs.

V2: Removed the NULL checks for the workqueues in patches 1 and 2, as they
can never be NULL while at close_ctree() (they can only be NULL in error paths from open_ctree()).

Filipe Manana (4):
btrfs: fix non-empty delayed iputs list on unmount due to endio workers
btrfs: fix non-empty delayed iputs list on unmount due to compressed write workers
btrfs: move __btrfs_bio_end_io() code into its single caller
btrfs: move btrfs_cleanup_bio() code into its single caller

 fs/btrfs/bio.c     | 36 ++++++++++++++----------------------
 fs/btrfs/disk-io.c | 21 +++++++++++++++++++++
 2 files changed, 35 insertions(+), 22 deletions(-)
Signature · 1 line
2.45.2