Skip to content

Minor cleanups in common/

Nirjhar Roy (IBM) fstests linux-ext4 linux-xfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 8 repliesIn review
  2. v36 patches 10 repliesSuperseded
  3. v25 patches 20 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches14 repliesSuperseded

Changes in v4 from the cover letter

1. Added R.Bs from Zorro and Ritesh in patch 2 of [v3]
2. Updated the definition of _exit() - explicitly set the value "status" only if it is passed.
3. Updated the description comment for _exit().

[1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/
[2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
[3] https://lore.kernel.org/all/[email protected]/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6generic/749: Remove redundant sourcing of common/rctests/generic/749+0 -10 replies
2/6generic/367: Remove redundant sourcing of common/configtests/generic/367+0 -11 reply
3/6check: Remove redundant _test_mount in checkcheck+2 -61 reply
4/6check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rccheck common/preamble common/rc+3 -21 reply
5/6common/config: Introduce _exit wrapper around exit commandcommon/config+9 -01 reply
6/6common: exit --> _exitcommon/btrfs common/ceph common/config +8 more+78 -844 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongDave ChinnerRitesh Harjani (IBM)Zorro Lang
1/6R-b R-b R-b
2/6R-b R-b R-b
3/6R-b R-b R-b
4/6R-b R-b R-b
5/6R-b R-b R-b
6/6R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/6] Minor cleanups in common/

This patch series removes some unnecessary sourcing of common/rc and decouples the call to init_rc() from the sourcing of common/rc. This is proposed in [1] and [2]. It also removes direct usage of exit command with a _exit wrapper. The individual patches have the details.

[v3] --> v4
1. Added R.Bs from Zorro and Ritesh in patch 2 of [v3]
2. Updated the definition of _exit() - explicitly set the value "status" only if it is passed.
3. Updated the description comment for _exit().

[1] https://lore.kernel.org/all/20250206155251.GA21787@frogsfrogsfrogs/
[2] https://lore.kernel.org/all/20250210142322.tptpphdntglsz4eq@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com/
[3] https://lore.kernel.org/all/[email protected]/

[v1] https://lore.kernel.org/all/[email protected]/
[v2] https://lore.kernel.org/all/[email protected]/
[v3] https://lore.kernel.org/all/[email protected]/

Nirjhar Roy (IBM) (6):
generic/749: Remove redundant sourcing of common/rc generic/367: Remove redundant sourcing of common/config
check: Remove redundant _test_mount in check check,common{rc,preamble}: Decouple init_rc() call from sourcing
common/rc
common/config: Introduce _exit wrapper around exit command
common: exit --> _exit

 check             |  10 ++---
 common/btrfs      |   6 +--
 common/ceph       |   2 +-
 common/config     |  16 +++++--
 common/dump       |  11 +++--
 common/ext4       |   2 +-
 common/populate   |   2 +-
 common/preamble   |   3 +-
 common/punch      |  13 +++---
 common/rc         | 107 ++++++++++++++++++++++------------------------
 common/repair     |   4 +-
 common/xfs        |   8 ++--
 tests/generic/367 |   1 -
 tests/generic/749 |   1 -
 14 files changed, 92 insertions(+), 94 deletions(-)

--
2.34.1