Skip to content

Linear temporal logic monitors for RT application

Nam Cao linux-riscv linux-trace-kernel lkml oe-kbuild-all 13 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v13 Latest12 patches 0 repliesNew 1 of 12 applied
  2. v1212 patches 7 repliesSuperseded 1 of 12 applied
  3. v1121 patches 2 repliesSuperseded 1 of 21 applied
Earlier versions · 10
VersionPostedPatchesRepliesStatus
v1019 patches22 repliesSuperseded
v922 patches6 repliesSuperseded
v822 patches11 repliesSuperseded 1 of 22 applied
v722 patches2 repliesSuperseded 1 of 22 applied
v622 patches15 repliesSuperseded 1 of 22 applied
v523 patches4 repliesSuperseded 1 of 23 applied
v422 patches9 repliesSuperseded 1 of 22 applied
v322 patches10 repliesSuperseded 1 of 22 applied
v222 patches21 repliesSuperseded
v110 patches9 repliesSuperseded

Patches in v13 1 of 12 applied

#Subject and filesSizeRepliesApplied
1/12Add #undef TRACE_INCLUDE_FILEkernel/trace/rv/rv_trace.h+2 -10 replies
2/12printk: Make vprintk_deferred() publicinclude/linux/printk.h kernel/printk/internal.h+7 -10 replies
3/12panic: Add vpanic()include/linux/panic.h kernel/panic.c+15 -40 replies
4/12Let the reactors take care of buffersinclude/linux/rv.h include/rv/da_monitor.h kernel/trace/rv/reactor_panic.c +2 more+30 -420 replies
5/12rename CONFIG_DA_MON_EVENTS to CONFIG_RV_MON_EVENTSkernel/trace/rv/Kconfig kernel/trace/rv/rv.c+4 -40 replies
6/12Add support for LTL monitorsinclude/linux/rv.h include/rv/ltl_monitor.h kernel/fork.c +2 more+298 -80 replies
7/12Add rtapp container monitorkernel/trace/rv/Kconfig kernel/trace/rv/Makefile kernel/trace/rv/monitors/rtapp/Kconfig +2 more+48 -00 replies
8/12riscv: mm: Add page fault trace pointsarch/riscv/mm/fault.c+8 -00 repliesApplied
9/12Add rtapp_pagefault monitorkernel/trace/rv/Kconfig kernel/trace/rv/Makefile kernel/trace/rv/monitors/pagefault/Kconfig +5 more+190 -00 replies
10/12Add rtapp_sleep monitorkernel/trace/rv/Kconfig kernel/trace/rv/Makefile kernel/trace/rv/monitors/sleep/Kconfig +5 more+556 -10 replies
11/12Add documentation for rtapp monitorDocumentation/trace/rv/index.rst Documentation/trace/rv/monitor_rtapp.rst+134 -00 replies
12/12Allow to configure the number of per-task monitorinclude/linux/rv.h include/linux/sched.h kernel/trace/rv/Kconfig +2 more+18 -170 replies

Reviews trailers per patch

11 of 12 patches have a Reviewed-by or Acked-by.

PatchGabriele MonacoPetr MladekAlexandre Ghiti
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12
7/12R-b
8/12A-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v13 thread

Cover letter [PATCH v13 00/12] RV: Linear temporal logic monitors for RT application

Real-time applications may have design flaws causing them to have unexpected latency. For example, the applications may raise page faults, or may be blocked trying to take a mutex without priority inheritance.

However, while attempting to implement DA monitors for these real-time rules, deterministic automaton is found to be inappropriate as the specification language. The automaton is complicated, hard to understand, and error-prone.

For these cases, linear temporal logic is found to be more suitable. The LTL is more concise and intuitive.

This series adds support for LTL RV monitor, and use it to implement two monitors for reporting problems with real-time tasks.

v12->v13 https://lore.kernel.org/linux-trace-kernel/[email protected]
- keep consistent format around __printf(1, 0)

v11->v12 https://lore.kernel.org/linux-trace-kernel/[email protected]
- drop the applied patches
- fixup build failure when CONFIG_PRINTK=n

v10->v11 https://lore.kernel.org/linux-trace-kernel/[email protected]/
- Split the patch adding LTL support into three smaller patches
- Keep comments and document within 80 columns
- Add a '&' to memset's argument to make it look more natural
Note: all changed patches are explicitly marked so below the --- line

v9->v10 https://lore.kernel.org/lkml/[email protected]
- rebase onto v6.16-rc1 (only the vpanic patch is changed)
- riscv: move page fault tracepoints back to be after kprobe pagefault handling
- drop x86 tracepoint patches, they have already been applied
- drop arm64 tracepoint patch. It requires further discussion and will be sent separately.
- pagefault monitor: set dependency on x86 and riscv, only these archs have the required tracepoints right now.

v8->v9 https://lore.kernel.org/lkml/[email protected]/
- Move page faults tracepoints to be before kprobe pagefault handling
- Add guidance into Kconfig entries whether they should be enabled
- Replace TRACE_EVENT with DECLARE_EVENT_CLASS for the tracepoint classes, so that the class names are not wrongly exposed to userspace

v7->v8 https://lore.kernel.org/lkml/[email protected]/
- Fix some pylint warnings
- Fix some bugs with some currently-unused operators in the ltl2ba.py script
- sleep monitor: Allow all FUTEX_WAIT_* as valid sleep reason

v6->v7 https://lore.kernel.org/lkml/[email protected]/
- Add missing parameter description for vpanic()
- Remove the now-redundant CFLAGS_fault.o for x86
- Change #if to #ifdef to resolve a build warning
- rtapp/sleep monitor:
+ Handle the case where an RT task "aborts" the sleep by setting state to TASK_RUNNING. This case previously caused a false positive. Fix it by adding "ABORT_SLEEP" as an RT-safe wake.
+ Also allow CLOCK_TAI for real-time tasks.

v5->v6 https://lore.kernel.org/lkml/[email protected]
- sleep monitor: Drop the block_on_rt_mutex tracepoints. The contention tracepoints are sufficient.

v4->v5 https://lore.kernel.org/lkml/[email protected]
- sleep monitor: Fix a false positive due to a race with waking and scheduling.
- sleep monitor: Add block_on_rt_mutex tracepoints and use them for BLOCK_ON_RT_MUTEX, instead of trace_sched_pi_setprio
- sleep monitor: tighten the rule on nanosleep: only clock_nanosleep() with TIMER_ABSTIME and CLOCK_MONOTONIC is allowed
- add comments explaining why it is correct to treat PI-boosted tasks as real-time tasks.

It should be noted that due to the changes in v5, 'perf' does not work as well as before, because sometimes the errors happen out of the real-time tasks' contexts. Fixing this is left for future work.

stress-ng is also far noisier in v5, because the rule on nanosleep is tightened.

v3->v4 https://lore.kernel.org/lkml/[email protected]
- support deadline tasks
- rtapp_sleep: use sched_pi_setprio tracepoint instead of contention tracepoints for BLOCK_ON_RT_MUTEX, so that proxy lock is covered.
- fix the scripts generating an "slightly" incorrect verification automaton
- makes rtapp monitor depends on RV_PER_TASK_MONITORS >= 2
- make the event tracepoint output a bit more readable
- some documentation's format fixes

v2->v3 https://lore.kernel.org/lkml/[email protected]/
- fix a problem with sleep monitor's specification (around KTHREAD_SHOULD_STOP)
- merge the patches that move the dot2k/rvgen scripts around
- pull panic/printk changes into separate patches
- fixup some build errors
- fixup monitor's init function return code
- fix some flake8 warnings with the scripts
- add some references to LTL documentation
- fixup some mistakes with rtapp documentation
- fixup capitalization mistake with monitor_synthesis.rst
- remove the now-redundant macro RV_PER_TASK_MONITORS

v1->v2 https://lore.kernel.org/lkml/[email protected]/
- Integrate the LTL scripts into the existing dot2k tool, taking advantage of the existing monitor generation scripts.
- Switch the struct ltl_monitor to use bitmap instead of an array, to optimize memory usage.
- Correct the generated code to be non-deterministic state machine, instead of deterministic state machine
- Put common code for all LTL monitors into a single file (include/rv/ltl_monitor.h), reducing code duplication
- Change the LTL monitors to make user of container. Add a bug fix to container while at it.
- Make the number of per-task monitor configurable

Cc Petr Mladek <[email protected]>
Cc John Ogness <[email protected]>
Cc Sergey Senozhatsky <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Palmer Dabbelt <[email protected]>
Cc Albert Ou <[email protected]>
Cc Alexandre Ghiti <[email protected]>

Nam Cao (12):
rv: Add #undef TRACE_INCLUDE_FILE
printk: Make vprintk_deferred() public
panic: Add vpanic()
rv: Let the reactors take care of buffers
rv: rename CONFIG_DA_MON_EVENTS to CONFIG_RV_MON_EVENTS
rv: Add support for LTL monitors
rv: Add rtapp container monitor
riscv: mm: Add page fault trace points
rv: Add rtapp_pagefault monitor
rv: Add rtapp_sleep monitor
rv: Add documentation for rtapp monitor
rv: Allow to configure the number of per-task monitor

 Documentation/trace/rv/index.rst              |   1 +
 Documentation/trace/rv/monitor_rtapp.rst      | 133 +++++++++
 arch/riscv/mm/fault.c                         |   8 +
 include/linux/panic.h                         |   3 +
 include/linux/printk.h                        |   7 +
 include/linux/rv.h                            |  75 ++++-
 include/linux/sched.h                         |   8 +-
 include/rv/da_monitor.h                       |  45 +--
 include/rv/ltl_monitor.h                      | 184 +++++++++++++
 kernel/fork.c                                 |   5 +-
 kernel/panic.c                                |  16 +-
 kernel/printk/internal.h                      |   1 -
 kernel/trace/rv/Kconfig                       |  27 +-
 kernel/trace/rv/Makefile                      |   3 +
 kernel/trace/rv/monitors/pagefault/Kconfig    |  20 ++
 .../trace/rv/monitors/pagefault/pagefault.c   |  88 ++++++
 .../trace/rv/monitors/pagefault/pagefault.h   |  64 +++++
 .../rv/monitors/pagefault/pagefault_trace.h   |  14 +
 kernel/trace/rv/monitors/rtapp/Kconfig        |  11 +
 kernel/trace/rv/monitors/rtapp/rtapp.c        |  33 +++
 kernel/trace/rv/monitors/rtapp/rtapp.h        |   3 +
 kernel/trace/rv/monitors/sleep/Kconfig        |  22 ++
 kernel/trace/rv/monitors/sleep/sleep.c        | 237 ++++++++++++++++
 kernel/trace/rv/monitors/sleep/sleep.h        | 257 ++++++++++++++++++
 kernel/trace/rv/monitors/sleep/sleep_trace.h  |  14 +
 kernel/trace/rv/reactor_panic.c               |   8 +-
 kernel/trace/rv/reactor_printk.c              |   8 +-
 kernel/trace/rv/rv.c                          |  10 +-
 kernel/trace/rv/rv_reactors.c                 |   2 +-
 kernel/trace/rv/rv_trace.h                    |  52 +++-
 tools/verification/models/rtapp/pagefault.ltl |   1 +
 tools/verification/models/rtapp/sleep.ltl     |  22 ++
 32 files changed, 1307 insertions(+), 75 deletions(-)
 create mode 100644 Documentation/trace/rv/monitor_rtapp.rst
 create mode 100644 include/rv/ltl_monitor.h
 create mode 100644 kernel/trace/rv/monitors/pagefault/Kconfig
 create mode 100644 kernel/trace/rv/monitors/pagefault/pagefault.c
 create mode 100644 kernel/trace/rv/monitors/pagefault/pagefault.h
 create mode 100644 kernel/trace/rv/monitors/pagefault/pagefault_trace.h
 create mode 100644 kernel/trace/rv/monitors/rtapp/Kconfig
 create mode 100644 kernel/trace/rv/monitors/rtapp/rtapp.c
 create mode 100644 kernel/trace/rv/monitors/rtapp/rtapp.h
 create mode 100644 kernel/trace/rv/monitors/sleep/Kconfig
 create mode 100644 kernel/trace/rv/monitors/sleep/sleep.c
 create mode 100644 kernel/trace/rv/monitors/sleep/sleep.h
 create mode 100644 kernel/trace/rv/monitors/sleep/sleep_trace.h
 create mode 100644 tools/verification/models/rtapp/pagefault.ltl
 create mode 100644 tools/verification/models/rtapp/sleep.ltl
Signature · 1 line
2.39.5