Add optional-counters binding support
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Changes in v1 from the cover letter
* Added new patch which removed dependency of CONFIG_INFINIBAND_USER_ACCESS fron fs.c
v0: https://lore.kernel.org/linux-rdma/[email protected]/
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | RDMA/mlx5: Add optional counters for RDMA_TX/RX_packets/bytesdrivers/ drivers/ drivers/ +1 more | +133 | 0 replies | |
| 2/6 | RDMA/core: Create and destroy rdma_counter using rdma_zalloc_drv_obj()drivers/ drivers/ drivers/ +2 more | +30 | 0 replies | |
| 3/6 | RDMA/core: Add support to optional-counters binding configurationdrivers/ drivers/ include/ +1 more | +41 | 0 replies | |
| 4/6 | RDMA/core: Pass port to counter bind/unbind operationsdrivers/ drivers/ drivers/ +2 more | +17 | 0 replies | |
| 5/6 | RDMA/mlx5: Compile fs.c regardless of INFINIBAND_USER_ACCESS configdrivers/ drivers/ drivers/ +1 more | +7 | 0 replies | |
| 6/6 | RDMA/mlx5: Support optional-counters binding for QPsdrivers/ drivers/ drivers/ +2 more | +546 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Mark Bloch |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH rdma-next v1 0/6] Add optional-counters binding support
Changelog:
v1:
* Added new patch which removed dependency of CONFIG_INFINIBAND_USER_ACCESS fron fs.c
v0: https://lore.kernel.org/linux-rdma/[email protected]/
--------------------------------------------------------------------------------
From Patrisious,
Add optional-counters binding support together with new packets/bytes counters. Previously optional-counters were on a per link basis, this series allows users to bind optional-counters to a specific counter, which allows tracking optional-counter over a specific QP group.
The support is added for both binding modes, automatic and manual, in both cases the bound optional counters are those that are currently configured over the link when trying to bind the QP.
In addition introduce four new optional-counters :rdma_tx_bytes, rdma_tx_packets, rdma_rx_bytes, rdma_rx_packets That just as their name implies allow tracking RDMA egress and ingress traffic.
This is exposed to users through the iproute2 package which needs to be updated as well to provide the support for this feature.
Example commands:
- rdma stat set link rocep8s0f0/1 optional-counters rdma_tx_bytes,rdma_rx_packets
Enables rdma_tx_bytes and rdma_rx_packets optional-counters over the link.
- rdma stat qp set link rocep8s0f0/1 auto type on optional-counters on Enabled link automatic counter binding for QPs of same type, with optional-counter binding support.
- rdma stat qp bind link rocep8s0f0/1 lqpn 134 Manually bind QP number 134 to all available counters.
- rdma stat qp bind link rocep8s0f0/1 lqpn 134 cntn 4 Manually bind QP number 134 to counter number 4 depending on its configured counters.
Thanks
Patrisious Haddad (6):
RDMA/mlx5: Add optional counters for RDMA_TX/RX_packets/bytes RDMA/core: Create and destroy rdma_counter using rdma_zalloc_drv_obj() RDMA/core: Add support to optional-counters binding configuration RDMA/core: Pass port to counter bind/unbind operations RDMA/mlx5: Compile fs.c regardless of INFINIBAND_USER_ACCESS config RDMA/mlx5: Support optional-counters binding for QPs
drivers/infiniband/core/counters.c | 52 +-- drivers/infiniband/core/device.c | 2 + drivers/infiniband/core/nldev.c | 18 +- drivers/infiniband/core/verbs.c | 2 +- drivers/infiniband/hw/mlx5/Makefile | 2 +- drivers/infiniband/hw/mlx5/counters.c | 195 ++++++++++- drivers/infiniband/hw/mlx5/counters.h | 15 + drivers/infiniband/hw/mlx5/fs.c | 483 +++++++++++++++++++++++++- drivers/infiniband/hw/mlx5/fs.h | 15 - drivers/infiniband/hw/mlx5/mlx5_ib.h | 20 ++ include/linux/mlx5/device.h | 4 +- include/rdma/ib_verbs.h | 11 +- include/rdma/rdma_counter.h | 7 +- include/uapi/rdma/rdma_netlink.h | 2 + 14 files changed, 766 insertions(+), 62 deletions(-)
Signature · 1 line
2.48.1