Skip to content

Fixes packet processes after vif is stopped

Remi Pommarel linux-wireless lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wifi: mac80211: Update skb's NULL key in ieee80211_tx_h_select_key()net/mac80211/tx.c+6 -05 replies
2/2wifi: mac80211: Purge vif txq in ieee80211_do_stop()net/mac80211/iface.c+3 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fixes packet processes after vif is stopped

Those are a couple of fixes that prevent crashes due to processing packets (especially multicast ones) for TX after vif is stopped (either after a mesh interface left the group or interface is put down).

The first one ensure the key info passed to drivers through ieee80211 skb control block is up to date, even after key removal.

The second one ensure no packets get processed after vif driver private data is cleared in ieee80211_do_stop().

As I tried to explain in second patch footnote, I can still see a theoretical reason that packets get queued after ieee80211_do_stop() call. But I was not able to reproduce it, so I may be missing a something here; making that more as an open question.

Remi Pommarel (2):
wifi: mac80211: Update skb's NULL key in ieee80211_tx_h_select_key()
wifi: mac80211: Purge vif txq in ieee80211_do_stop()

 net/mac80211/iface.c | 3 +++
 net/mac80211/tx.c    | 6 ++++++
 2 files changed, 9 insertions(+)
Signature · 1 line
2.40.0