Skip to content

Fix packets processed after vif is stopped

Remi Pommarel linux-mediatek linux-wireless lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 10 repliesIn review

Changes in v2 from the cover letter

- Add Fixes tag
- Clear SKB's control block key before in ieee80211_tx_dequeue()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wifi: mac80211: Update skb's control block key in ieee80211_tx_dequeue()net/mac80211/tx.c+1 -010 replies
2/2wifi: mac80211: Purge vif txq in ieee80211_do_stop()net/mac80211/iface.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH wireless v2 0/2] Fix packets processed after vif is stopped

Those are a couple of fixes that prevent crashes due to processing packets (especially multicast ones) for TX after vif is stopped (either after a mesh interface left the group or interface is put down).

The first one ensure the key info passed to drivers through ieee80211 skb control block is up to date, even after key removal.

The second one ensure no packets get processed after vif driver private data is cleared in ieee80211_do_stop().

v2:
- Add Fixes tag
- Clear SKB's control block key before in ieee80211_tx_dequeue()

    instead of ieee80211_tx_h_select_key()
  - Add wireless tag and fix type in subject
  - Because subject changed, v1 can be found at
    https://lore.kernel.org/lkml/[email protected]/

Remi Pommarel (2):
wifi: mac80211: Update skb's control block key in

    ieee80211_tx_dequeue()

wifi: mac80211: Purge vif txq in ieee80211_do_stop()

 net/mac80211/iface.c | 3 +++
 net/mac80211/tx.c    | 1 +
 2 files changed, 4 insertions(+)
Signature · 1 line
2.40.0