Skip to content

mfd: exynos-lpass: Fix some error handling paths

Christophe JAILLET kernel-janitors linux-arm-kernel linux-samsung-soc lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v14 patches 4 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()drivers/mfd/exynos-lpass.c+2 -30 replies
2/3mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in exynos_lpass_remove()drivers/mfd/exynos-lpass.c+0 -10 replies
3/3mfd: exynos-lpass: Fix another error handling path in exynos_lpass_probe()drivers/mfd/exynos-lpass.c+15 -101 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] mfd: exynos-lpass: Fix some error handling paths

This serie fixes several issues related to error handling paths in drivers/mfd/exynos-lpass.c.

I've split it in 3 patches to ease review, but it could be merge in only 1 patch if preferred.

Patch 1: Fix a leak in the error handling path of the probe. It should be straighforward. This patch is already R-b.

Patch 2: Slighly unsure of the order of the code. In the probe, we enable pm, then lpass, so should we disable lpass, then pm? This patch is already R-b.

Patch 3: Fix a leak in the error handling path of the probe. It should be straighforward. This replaces patch 3 and 4 of the v1.

All these patches are compile tested only.

Christophe JAILLET (3):
mfd: exynos-lpass: Fix an error handling path in exynos_lpass_probe()
mfd: exynos-lpass: Avoid calling exynos_lpass_disable() twice in
exynos_lpass_remove()
mfd: exynos-lpass: Fix another error handling path in
exynos_lpass_probe()

 drivers/mfd/exynos-lpass.c | 31 +++++++++++++++++--------------
 1 file changed, 17 insertions(+), 14 deletions(-)
Signature · 1 line
2.49.0