Skip to content

staging: rtl8723bs: Code cleanup patches

Erick Karanja linux-staging lkml outreachy 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 8 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- [PATCH 1/3]: Rename the subject line and improve on the subject body
- [PATCH 2/3]: Rename the subject line and improve on the subject body
- [PATCH 3/3]: Rename the subject line and improve in the subject body
improving code readability and consistency with standard kernel practices. The transformation was performed using Coccinelle.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypteddrivers/staging/rtl8723bs/core/rtw_recv.c+1 -18 replies
2/3staging: rtl8723bs: Modify struct sta_info attribute qos_optiondrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+2 -20 replies
3/3staging: rtl8723bs: Modify struct sta_info attribute qos_option and ieee8021x_blockeddrivers/staging/rtl8723bs/core/rtw_ap.c+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] staging: rtl8723bs: Code cleanup patches

This patchset refactors the rtl8723bs driver by replacing integer literals (1 and 0) with true and false in instances where values are already defined with true or false but some defination contains (1 or 0)

Changes in v2:
- [PATCH 1/3]: Rename the subject line and improve on the subject body
- [PATCH 2/3]: Rename the subject line and improve on the subject body
- [PATCH 3/3]: Rename the subject line and improve in the subject body
improving code readability and consistency with standard kernel practices. The transformation was performed using Coccinelle.

below is the coccinelle script used:
@initialize:ocaml@
@@

let same_function p q =
(List.hd p).Coccilib.current_element = (List.hd q).Coccilib.current_element

@r@
expression e;
position p;
symbol true,false;
@@

e =@p \(true\|false\)

@@
expression r.e;
position q : script:ocaml(r.p) { same_function p q }; @@

e =@q
(
- 1
+ true
|
- 0
+ false
)

@s@
type T;
T e;
identifier fld;
symbol true,false;
@@

e.fld = \(true\|false\)

@@
type s.T;
T e;
identifier s.fld;
@@

e.fld =
(
- 1
+ true
|
- 0
+ false
)

Erick Karanja (3):
staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted
staging: rtl8723bs: Modify struct sta_info attribute qos_option
staging: rtl8723bs: Modify struct sta_info attribute qos_option and

    ieee8021x_blocked
 drivers/staging/rtl8723bs/core/rtw_ap.c       | 12 ++++++------
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  4 ++--
 drivers/staging/rtl8723bs/core/rtw_recv.c     |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)
Signature · 1 line
2.43.0