Skip to content

Cleanup duplicate NULL tests on a value

Abraham Samuel Adekunle linux-staging lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest2 patches 2 repliesIn review
  2. v51 patch 4 repliesSuperseded
  3. v41 patch 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v31 patch10 repliesSuperseded
v23 patches8 repliesSuperseded
v12 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Splitted patch v4 into a patchset with two patches so as to
proper explanation of each change due to different code patterns
in the change as suggested by Julia Lawall.
- Modified commit messages in each patch to properly explain the changes show the initial NULL tests on the value.
- Added Subject title to each patch to be specific to the value being NULL tested.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: rtl8723bs: Remove duplicate NULL tests on pstatdrivers/staging/rtl8723bs/core/rtw_mlme_ext.c+1 -11 reply
2/2staging: rtl8723bs: Prevent duplicate NULL tests on psta pointerdrivers/staging/rtl8723bs/core/rtw_xmit.c+30 -321 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDan Carpenter
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/2] Cleanup duplicate NULL tests on a value

Changes in v5:
- Splitted patch v4 into a patchset with two patches so as to
proper explanation of each change due to different code patterns
in the change as suggested by Julia Lawall.
- Modified commit messages in each patch to properly explain the changes show the initial NULL tests on the value.
- Added Subject title to each patch to be specific to the value being NULL tested.
Changed in v4:

	- Separated initially integrated suggested change
	 "use modulo % 4096 over & 0xfff" to a different patch.

Changes in v3:
- Changed other cases to use modulo (% 4096) over (& 0xofff).
- Modified commit message to reflect these changes.
Changes in v2:
- Dropped patch files for media drivers from patchset as it is not meant for outreachy applicants.
- Added full-stop aign to text in commit message.
- Made code more readable by adding a line break.
- Changed cases to use modulo (% 4096) over (& 0xfff).
Changes in v1
- Patch for drivers/staging/media/av7110/sp8870.c and
- drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
is split into two different patches in the patchset for use by the different driver maintainers.
- Added subject title for each of the separated patches.
- Patch 1: Removed unnecessary curly braces {} initially inserted.
- Patch 2: Unnecessary {} was also removed for v1.

Abraham Samuel Adekunle (2):
staging: rtl8723bs: Remove duplicate NULL tests on pstat
staging: rtl8723bs: Prevent duplicate NULL tests on psta pointer

 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  2 +-
 drivers/staging/rtl8723bs/core/rtw_xmit.c     | 62 +++++++++----------
 2 files changed, 31 insertions(+), 33 deletions(-)
Signature · 1 line
2.34.1