Skip to content

btrfs: fsstress hang fix for large data folios

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs: remove unnecessary early exits in delalloc folio lock and unlockfs/btrfs/extent_io.c+0 -83 replies
2/3btrfs: use folio_contains() for EOF detectionfs/btrfs/compression.c fs/btrfs/extent_io.c+4 -45 replies
3/3btrfs: get rid of filemap_get_folios_contig() callsfs/btrfs/extent_io.c fs/btrfs/tests/extent-io-tests.c+3 -64 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchFilipe Manana
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs: fsstress hang fix for large data folios

With my local large data folios enabled btrfs, fsstress can hit a hang where lock_delalloc_folios() fails to lock a folio.

It turns our that filemap_get_folios_contig() can return duplicated folios, which is fatal for lock_delalloc_folios() and unlock_delalloc_folio().

The series here is to address the annonying filemap_get_folios_contig() behavior for large folios.

The first patch is a small cleanup to remove unnecessary early exits, exposed during the next folio_contains() change.

The second patch uses folio_contains() to handle EOF detection for large folios.

The final one is the fix of filemap_get_folios_contig(), by getting rid of it.

Qu Wenruo (3):
btrfs: remove unnecessary early exits in delalloc folio lock and
unlock
btrfs: use folio_contains() for EOF detection
btrfs: get rid of filemap_get_folios_contig() calls

 fs/btrfs/compression.c           |  2 +-
 fs/btrfs/extent_io.c             | 20 +++++---------------
 fs/btrfs/tests/extent-io-tests.c |  3 +--
 3 files changed, 7 insertions(+), 18 deletions(-)
Signature · 1 line
2.49.0